After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761090 - Failed to set text from markup due to error parsing markup
Failed to set text from markup due to error parsing markup
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.18.x
Other Linux
: High critical
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-25 15:20 UTC by goddard
Modified: 2016-01-30 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Escape markup in search results and placebubble (1.57 KB, patch)
2016-01-26 11:49 UTC, Alaf 		committed Details | Review

Description goddard 2016-01-25 15:20:57 UTC 
Description of problem:
Failed to set text from markup due to error parsing markup

Version-Release number of selected component (if applicable):
3.18.2

How reproducible:
Always

Steps to Reproduce:
1. search for new york <enter>
2.
3.

Actual results:
(org.gnome.Maps:7841):
(org.gnome.Maps:9235):
(org.gnome.Maps:10083): Gtk-WARNING **: Failed to set text 'New York, V&G Subdivision, Barangay 109-A, 6500, Tacloban, Leyte, Philippines' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &amp;

Expected results:
no warnings printed due to failure of setting text from markup

Additional info:
I've got different line? numbers on different runs of gnome-maps while trying to reproduce this, hence the (org.gnome.Maps:xxxx):
Comment 1 Jonas Danielsson 2016-01-25 16:10:13 UTC 
Yes, This should be escaped, I thought we had code that did this.

Will mark as gnome-love since it seems like a nice entry bug.
Comment 2 Alaf 2016-01-26 11:49:31 UTC 
Created attachment 319744 [details] [review]
Escape markup in search results and placebubble
Comment 3 Jonas Danielsson 2016-01-26 12:28:13 UTC 
Review of attachment 319744 [details] [review]:

Thanks!

Is there no common place for this to be done? Like the placeFormatter.js?
Comment 4 Alaf 2016-01-26 13:45:58 UTC 
I tried that. It can be done but then placeBubble shows &amp; since it uses placeFormatter differently. 
Also without this patch placebBubble skips the string entirely.

For testing, search 
New York, V&G Subdivision, Barangay 109-A, 6500
and select last item. V Henry & carl Lomb drive .
Comment 5 Jonas Danielsson 2016-01-30 10:37:14 UTC 
Attachment 319744 [details] pushed as b6772c7 - Escape markup in search results and placebubble