GNOME Bugzilla – Bug 76109
settings-daemon: BOTH_HORIZ for GtkToolbar
Last modified: 2004-12-22 21:47:04 UTC
Package: control-center Severity: enhancement Version: 1.99.4 Synopsis: settings-daemon: BOTH_HORIZ for GtkToolbar Bugzilla-Product: control-center Bugzilla-Component: settings-daemon Description: gtk2 support GTK_TOOLBAR_BOTH_HORIZ, with classic three icon/text/both type of toolbar. but gnome2 does not support this enhancement for preference. I think this is matter of settings-daemon. but could not find point to hack in cvs source. what a poor ability for me :( would you pliz check it out? ------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-03-24 05:27 ------- Reassigning to the default owner of the component, control-center-maint@bugzilla.gnome.org.
most suspect part of code is gnome-settings-xsettings.c:56: { "/desktop/gnome/gtk-toolbar-style", "Gtk/ToolbarStyle", GCONF_VALUE_STRING, but there's no entry like that via gconf-editor. only /desktop/gnome/intercace/toolbar_syle=both.
Hrm... I don't think that this is a GNOME problem- if you can't see the option in gconf-editor, then the schemas are not being installed correctly by gtk. Is that the case?
I remember a schema's comment told icons/text/both are the only case, not both_horiz. and, schema is a part of gnome(for gconf), so it's guilty of gnome, not gtk. and I use ximian package. I believe their reliability.
Is this a libgnome problem then, jody?
I really confused. It's totally hidden. Deadly headache.. I understand like this: settings system is something I couldn't find yet. the core parser read gconf's /desktop/gnome/* and give the properties to real widgets as proper type and form. what the hell is that? I've been grep icons or both or BOTH, etc. which seems to relative to GTK_TOOLBAR_BOTH_HORIZ. perfectly failed. I almost feel I'm tricked. :-( I do believe it's not hard to implement, 'cos already three classic kinds of toolbar_style is there. Hill is there, help me..
Updating all cc bugs that have the GNOME2 keyword set to the GNOME2.0 milestone, to help jrb triage/prioritize cc bugs. Filter on 'luis doing GNOME2 work' to ignore this spam.
*** Bug 78718 has been marked as a duplicate of this bug. ***
Simple fix is now in cvs. 1) to enum is stored as a string hence any string is valid from gconf's perspective. The editor would not know the valid entries. 2) The comment in the schema is a pseudo-contract so that people reading it will know it is an enum. I've added both_horiz. 3) The gnome-ui-settings capplet now has an entry for both_horiz 4) The libgnomui code that managed the setting now knows of both_horiz.
Jody: I really really thank you! :D
Created attachment 8175 [details] [review] gnome-ui-properties.c has broken enums of toolbar style
gnome-ui-properties.glade has broken toolbar style optionmenu. I tried to glade-2 *.glade to modify myself, but failed. glade2 freeze after modifying. pliz add new Both Horiz menuitem to the optionmenu. thanks.
plus, libbonoboui. it support both_horiz as well, or not?
This seems to work now.