After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760987 - [review] cleanup config import code for openvpn [th/import-cleanup-bgo760987]
[review] cleanup config import code for openvpn [th/import-cleanup-bgo760987]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-22 14:28 UTC by Thomas Haller
Modified: 2016-01-23 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-01-22 14:28:32 UTC 
some cleanup.

The code is really not stellar (yet), as it also doesn't properly handle quoting according to openvpn's manual page.

Just a few early fixes.
Comment 1 Thomas Haller 2016-01-22 14:29:09 UTC 
th/import-cleanup-bgo760987
Comment 2 Beniamino Galvani 2016-01-22 16:02:05 UTC 
(In reply to Thomas Haller from comment #1)
> th/import-cleanup-bgo760987

Looks good.
Comment 3 Dan Williams 2016-01-22 21:34:38 UTC 
LGTM