After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760981 - aggregator: Add vfunc for overriding finish() behaviour
aggregator: Add vfunc for overriding finish() behaviour
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 739010
 
 
Reported: 2016-01-22 10:44 UTC by Sebastian Dröge (slomo)
Modified: 2017-12-04 15:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
aggregator: add finish_buffer() vfunc (4.48 KB, patch)
2017-12-04 11:27 UTC, Tim-Philipp Müller 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-01-22 10:44:41 UTC 
See https://bugzilla.gnome.org/show_bug.cgi?id=760733#c3
Comment 1 Sebastian Dröge (slomo) 2017-09-18 15:14:13 UTC 
That comment contains a patch and explanation btw :)
Comment 2 Thibault Saunier 2017-09-19 15:51:33 UTC 
OK, what about my comment there? ie. Have a GstAggregator::finish_buffer vmethod which have to link up? (I am not sure why this feature should be specific to the audioaggregator).
Comment 3 Sebastian Dröge (slomo) 2017-09-19 17:02:33 UTC 
Sounds good to me
Comment 4 Tim-Philipp Müller 2017-12-04 11:27:03 UTC 
Created attachment 364902 [details] [review]
aggregator: add finish_buffer() vfunc

Like this?
Comment 5 Sebastian Dröge (slomo) 2017-12-04 14:43:45 UTC 
Comment on attachment 364902 [details] [review]
aggregator: add finish_buffer() vfunc

Yes