After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760962 - style: fix .diff .patch colors
style: fix .diff .patch colors
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
3.19.x
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-21 18:50 UTC by sébastien lafargue
Modified: 2016-01-25 01:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Changed colors regarding diff:added-lines and diff:changed-line and added gutter:added-line and gutter:changed-line (3.74 KB, patch)
2016-01-24 03:11 UTC, sadath.anwar17 		committed Details | Review

Description sébastien lafargue 2016-01-21 18:50:47 UTC 
The .diff and .patch colors are not easily readable on screen,
especially the light green on added lines
Comment 1 Christian Hergert 2016-01-21 19:07:01 UTC 
The complexity here is that the IdeLineChangeGutterRenderer uses diff:added-line and diff:changed-line for the colors to use in the left gutter.

We need to add a new style to builder.xml and builder-dark.xml to use for the gutter, so that diff:added-line and diff:changed-line can be changed while preserving the color in the gutter.

I would suggest gutter:added-line and gutter:changed-line as new styles (and update libide/ide-line-change-gutter-renderer.c) with fallbacks to diff:added-line and diff:changed-line.
Comment 2 sadath.anwar17 2016-01-24 03:11:35 UTC 
Created attachment 319598 [details] [review]
Changed colors regarding diff:added-lines and diff:changed-line and added gutter:added-line and gutter:changed-line
Comment 3 Christian Hergert 2016-01-25 01:31:38 UTC 
Thanks!

Added a followup commit to tweak the color a bit.

Attachment 319598 [details] pushed as 5946b9b - Changed colors regarding diff:added-lines and diff:changed-line and added gutter:added-line and gutter:changed-line