After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760949 - decodebin: Correctly expose pads from elements that have directly exposable pads
decodebin: Correctly expose pads from elements that have directly exposable pads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal blocker
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-21 16:41 UTC by Sebastian Dröge (slomo)
Modified: 2016-01-25 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
decodebin: Correctly expose pads from elements that have directly exposable pads (4.89 KB, patch)
2016-01-21 16:42 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-01-21 16:41:59 UTC 
See commit message. This is a regression caused by
44871680f02f5eae970c3d4f87b4e168ec412a25, i.e.
https://bugzilla.gnome.org/show_bug.cgi?id=742924
Comment 1 Sebastian Dröge (slomo) 2016-01-21 16:42:05 UTC 
Created attachment 319513 [details] [review]
decodebin: Correctly expose pads from elements that have directly exposable pads

analyze_new_pad() can return a new decode chain, which might have a new
GstDecodePad in the end. We should use those two for expose_pad() and not the
original ones that were passed to analyze_new_pad().

This fails when having a demuxer element that has raw pads immediately or
if a decoder with raw caps is after an adaptive demuxer.
Comment 2 Sebastian Dröge (slomo) 2016-01-25 12:52:01 UTC 
Attachment 319513 [details] pushed as acd08a8 - decodebin: Correctly expose pads from elements that have directly exposable pads