After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760946 - [review] dcbw/die-die-die-dbus-glib-bgo760946: remove last dbus-glib usage in applet/editor
[review] dcbw/die-die-die-dbus-glib-bgo760946: remove last dbus-glib usage in...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review nm-1-2
 
 
Reported: 2016-01-21 15:57 UTC by Thomas Haller
Modified: 2016-02-19 17:35 UTC
See Also:
GNOME target: 3.20
GNOME version: ---


Description Thomas Haller 2016-01-21 15:57:18 UTC 
On master, nm-connection-editor still uses dbus-glib to implement a D-Bus service.

src/connection-editor/nm-connection-editor-service.xml

<node name="/">
  <interface name="org.gnome.nm_connection_editor">
    <method name="Start">
      <annotation name="org.freedesktop.DBus.GLib.CSymbol" value="impl_start"/>
      <arg name="args" type="a{sv}" direction="in"/>
    </method>
  </interface>
</node>




This should be reworked to use gio to get rid of the dbus-glib requirement for nm-c-e.
Comment 1 Dan Williams 2016-02-18 20:41:09 UTC 
Please review dcbw/die-die-die-dbus-glib-bgo760946
Comment 2 Beniamino Galvani 2016-02-19 12:32:52 UTC 
LGTM.
Comment 3 Dan Williams 2016-02-19 17:35:00 UTC 
Fixed up for an issue I saw, repushed to the branch (just for the record), and merged to master.

7b1e58c427751befbbd596a6b41cef580a8dfb05
9b002809514ae905b2ad9590a794c4a2503b89e7
096da067acb73b4b4af90f70d27363b699482fbc