After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760924 - gnome-shell crashed after selecting vpn
gnome-shell crashed after selecting vpn
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-21 08:05 UTC by wwn
Modified: 2017-11-02 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description wwn 2016-01-21 08:05:05 UTC
Arch Linux 64bit full updated

Name                 : networkmanager
Version              : 1.0.10-2
Beschreibung         : Network Management daemon
Architektur          : x86_64

After logging in I'm usually chose the option to select a configured vpn in the right upper corner (select the little arrow down, select the little arrow to right at "vpn disabled" and move the button). While I'm doing this today the screen goes black, followed by the grey screen with the "oh no, something has gone wrong" - message. Afterwards I can relog or reboot. The problem does not disappear.

journalctl reports:
Jan 20 20:33:46 t420s NetworkManager[433]: <info>  Starting VPN service 'openvpn'...
Jan 20 20:33:46 t420s NetworkManager[433]: <info>  VPN service 'openvpn' started (org.freedesktop.NetworkManager.openvpn), PID 2094
Jan 20 20:33:46 t420s kernel: tun: Universal TUN/TAP device driver, 1.6
Jan 20 20:33:46 t420s kernel: tun: (C) 1999-2004 Max Krasnyansky <maxk@qualcomm.com>
Jan 20 20:33:46 t420s NetworkManager[433]: <info>  VPN service 'openvpn' appeared; activating connections
Jan 20 20:33:46 t420s kernel: gnome-shell[815]: segfault at 427b18008 ip 00007fa2e1026671 sp 00007ffd6ced9180 error 4 in libglib-2.0.so.0.4600.2[7fa2e0fc0000+10c000]
Jan 20 20:33:46 t420s NetworkManager[433]: <error> [1453318426.249052] [vpn-manager/nm-vpn-connection.c:1977] get_secrets_cb(): Failed to request VPN secrets #3: (4) No agents were available for this request.
Jan 20 20:33:46 t420s polkitd[469]: Unregistered Authentication Agent for unix-session:c2 (system bus name :1.61, object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale de_DE.utf8) (disconnected from bus)
Jan 20 20:33:46 t420s gnome-session[747]: gnome-session-binary[747]: WARNING: Application 'gnome-shell.desktop' killed by signal 11
Jan 20 20:33:46 t420s gnome-session-binary[747]: WARNING: Application 'gnome-shell.desktop' killed by signal 11
Jan 20 20:33:46 t420s systemd-coredump[2101]: Process 815 (gnome-shell) of user 1000 dumped core.
                                              
                                              Stack trace of thread 815:
                                              #0  0x00007fa2e1026671 g_slice_alloc (libglib-2.0.so.0)
...
Comment 1 Rui Matos 2016-01-21 11:13:38 UTC
Can you attach the full stack trace? coredumpctl should allow you to retrieve it
Comment 2 Raimund Machacek 2016-01-21 11:29:10 UTC
I have the same problem, here is the stacktrace:

           PID: 5739 (gnome-shell)
           UID: 1000 (raimund)
           GID: 100 (users)
        Signal: 11 (SEGV)
     Timestamp: Don 2016-01-21 12:15:08 CET (7min ago)
  Command Line: /usr/bin/gnome-shell
    Executable: /usr/bin/gnome-shell
 Control Group: /user.slice/user-1000.slice/session-c5.scope
          Unit: session-c5.scope
         Slice: user-1000.slice
       Session: c5
     Owner UID: 1000 (raimund)
       Boot ID: 4207591ad21d4596b32c29f530fb2849
    Machine ID: aed04b646d024ff9b7f0eca8b06378d5
      Hostname: Camelot
      Coredump: /var/lib/systemd/coredump/core.gnome-shell.1000.4207591ad21d4596b32c29f530fb2849.5739.1453374908000000.lz4
       Message: Process 5739 (gnome-shell) of user 1000 dumped core.
                
                Stack trace of thread 5739:
                #0  0x00007f8aec5de671 g_slice_alloc (libglib-2.0.so.0)
                #1  0x00007f8aec5fc91d g_variant_new_from_bytes (libglib-2.0.so.0)
                #2  0x00007f8aec5f5b77 n/a (libglib-2.0.so.0)
                #3  0x00007f8aecdbc52a n/a (libgio-2.0.so.0)
                #4  0x00007f8aecdbd645 g_dbus_message_new_method_call (libgio-2.0.so.0)
                #5  0x00007f8aecdb4e19 n/a (libgio-2.0.so.0)
                #6  0x00007f8aecdb8fa7 g_dbus_connection_signal_unsubscribe (libgio-2.0.so.0)
                #7  0x00007f8aecdc2959 n/a (libgio-2.0.so.0)
                #8  0x00007f8aec89ae0a g_object_unref (libgobject-2.0.so.0)
                #9  0x00007f8aec5b025a n/a (libglib-2.0.so.0)
                #10 0x00007f8aec5b11a3 g_hash_table_remove_all (libglib-2.0.so.0)
                #11 0x00007f8aec5b11de g_hash_table_destroy (libglib-2.0.so.0)
                #12 0x00007f8aea226eee n/a (libsecret-1.so.0)
                #13 0x00007f8aecd58b18 n/a (libgio-2.0.so.0)
                #14 0x00007f8aec89ae0a g_object_unref (libgobject-2.0.so.0)
                #15 0x00007f8aea228169 n/a (libsecret-1.so.0)
                #16 0x00007f8aecd6a413 n/a (libgio-2.0.so.0)
                #17 0x00007f8aecd6aabe n/a (libgio-2.0.so.0)
                #18 0x00007f8aecdc2a1b n/a (libgio-2.0.so.0)
                #19 0x00007f8aecd6a413 n/a (libgio-2.0.so.0)
                #20 0x00007f8aecd6aabe n/a (libgio-2.0.so.0)
                #21 0x00007f8aecdb754a n/a (libgio-2.0.so.0)
                #22 0x00007f8aecd6a413 n/a (libgio-2.0.so.0)
                #23 0x00007f8aecd6a449 n/a (libgio-2.0.so.0)
                #24 0x00007f8aec5c1c7a g_main_context_dispatch (libglib-2.0.so.0)
                #25 0x00007f8aec5c2020 n/a (libglib-2.0.so.0)
                #26 0x00007f8aec5c2342 g_main_loop_run (libglib-2.0.so.0)
                #27 0x00007f8aedf65afc meta_run (libmutter.so.0)
                #28 0x00000000004021a7 main (gnome-shell)
                #29 0x00007f8aebfd7610 __libc_start_main (libc.so.6)
                #30 0x00000000004022d9 n/a (gnome-shell)
                
                Stack trace of thread 5801:
                #0  0x00007f8aec09bcf9 syscall (libc.so.6)
                #1  0x00007f8aec60687a g_cond_wait_until (libglib-2.0.so.0)
                #2  0x00007f8aec596a69 n/a (libglib-2.0.so.0)
                #3  0x00007f8aec5e9086 n/a (libglib-2.0.so.0)
                #4  0x00007f8aec5e8715 n/a (libglib-2.0.so.0)
                #5  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #6  0x00007f8aec0a013d __clone (libc.so.6)
                
                Stack trace of thread 5742:
                #0  0x00007f8aec09718d poll (libc.so.6)
                #1  0x00007f8aec5c1fbc n/a (libglib-2.0.so.0)
                #2  0x00007f8aec5c2342 g_main_loop_run (libglib-2.0.so.0)
                #3  0x00007f8aecdc5236 n/a (libgio-2.0.so.0)
                #4  0x00007f8aec5e8715 n/a (libglib-2.0.so.0)
                #5  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #6  0x00007f8aec0a013d __clone (libc.so.6)
                
                Stack trace of thread 5800:
                #0  0x00007f8aec09bcf9 syscall (libc.so.6)
                #1  0x00007f8aec60687a g_cond_wait_until (libglib-2.0.so.0)
                #2  0x00007f8aec596a69 n/a (libglib-2.0.so.0)
                #3  0x00007f8aec5e9086 n/a (libglib-2.0.so.0)
                #4  0x00007f8aec5e8715 n/a (libglib-2.0.so.0)
                #5  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #6  0x00007f8aec0a013d __clone (libc.so.6)
                
                Stack trace of thread 5741:
                #0  0x00007f8aec09718d poll (libc.so.6)
                #1  0x00007f8aec5c1fbc n/a (libglib-2.0.so.0)
                #2  0x00007f8aec5c20cc g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f8aec5c2109 n/a (libglib-2.0.so.0)
                #4  0x00007f8aec5e8715 n/a (libglib-2.0.so.0)
                #5  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #6  0x00007f8aec0a013d __clone (libc.so.6)
                
                Stack trace of thread 5782:
                #0  0x00007f8aec36807f pthread_cond_wait@@GLIBC_2.3.2 (libpthread.so.0)
                #1  0x00007f8adeaa24b0 PR_WaitCondVar (libnspr4.so)
                #2  0x00007f8ae7ee7816 n/a (libmozjs-24.so)
                #3  0x00007f8adeaa7d7b n/a (libnspr4.so)
                #4  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #5  0x00007f8aec0a013d __clone (libc.so.6)
                
                Stack trace of thread 5778:
                #0  0x00007f8aec09718d poll (libc.so.6)
                #1  0x00007f8aec5c1fbc n/a (libglib-2.0.so.0)
                #2  0x00007f8aec5c20cc g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f8ad237625d n/a (libdconfsettings.so)
                #4  0x00007f8aec5e8715 n/a (libglib-2.0.so.0)
                #5  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #6  0x00007f8aec0a013d __clone (libc.so.6)
                
                Stack trace of thread 5780:
                #0  0x00007f8aec09718d poll (libc.so.6)
                #1  0x00007f8ae8420f51 n/a (libpulse.so.0)
                #2  0x00007f8ae8412571 pa_mainloop_poll (libpulse.so.0)
                #3  0x00007f8ae8412c0e pa_mainloop_iterate (libpulse.so.0)
                #4  0x00007f8ae8412cc0 pa_mainloop_run (libpulse.so.0)
                #5  0x00007f8ae8420ee6 n/a (libpulse.so.0)
                #6  0x00007f8add5325f8 n/a (libpulsecommon-7.1.so)
                #7  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #8  0x00007f8aec0a013d __clone (libc.so.6)
                
                Stack trace of thread 5781:
                #0  0x00007f8aec36807f pthread_cond_wait@@GLIBC_2.3.2 (libpthread.so.0)
                #1  0x00007f8adeaa24b0 PR_WaitCondVar (libnspr4.so)
                #2  0x00007f8ae7e73e9e n/a (libmozjs-24.so)
                #3  0x00007f8adeaa7d7b n/a (libnspr4.so)
                #4  0x00007f8aec3624a4 start_thread (libpthread.so.0)
                #5  0x00007f8aec0a013d __clone (libc.so.6)


I can circumvent the crash by using the Network-Manager cli and activating the VPN directly:
nmcli connection up id MyVPN
Comment 3 wwn 2016-01-21 11:59:17 UTC
(In reply to Rui Matos from comment #1)
> Can you attach the full stack trace? coredumpctl should allow you to
> retrieve it

an 20 20:33:46 t420s NetworkManager[433]: <info>  Starting VPN service 'openvpn'...
Jan 20 20:33:46 t420s NetworkManager[433]: <info>  VPN service 'openvpn' started (org.freedesktop.NetworkManager.openvpn), PID 2094
Jan 20 20:33:46 t420s kernel: tun: Universal TUN/TAP device driver, 1.6
Jan 20 20:33:46 t420s kernel: tun: (C) 1999-2004 Max Krasnyansky <maxk@qualcomm.com>
Jan 20 20:33:46 t420s NetworkManager[433]: <info>  VPN service 'openvpn' appeared; activating connections
Jan 20 20:33:46 t420s kernel: gnome-shell[815]: segfault at 427b18008 ip 00007fa2e1026671 sp 00007ffd6ced9180 error 4 in libglib-2.0.so.0.4600.2[7fa2e0fc0000+10c000]
Jan 20 20:33:46 t420s NetworkManager[433]: <error> [1453318426.249052] [vpn-manager/nm-vpn-connection.c:1977] get_secrets_cb(): Failed to request VPN secrets #3: (4) No agents were available for this request.
Jan 20 20:33:46 t420s polkitd[469]: Unregistered Authentication Agent for unix-session:c2 (system bus name :1.61, object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale de_DE.utf8) (disconnected from bus)
Jan 20 20:33:46 t420s gnome-session[747]: gnome-session-binary[747]: WARNING: Application 'gnome-shell.desktop' killed by signal 11
Jan 20 20:33:46 t420s gnome-session-binary[747]: WARNING: Application 'gnome-shell.desktop' killed by signal 11
Jan 20 20:33:46 t420s systemd-coredump[2101]: Process 815 (gnome-shell) of user 1000 dumped core.
                                              
                                              Stack trace of thread 815:
                                              #0  0x00007fa2e1026671 g_slice_alloc (libglib-2.0.so.0)
                                              #1  0x00007fa2e104491d g_variant_new_from_bytes (libglib-2.0.so.0)
                                              #2  0x00007fa2e103db77 n/a (libglib-2.0.so.0)
                                              #3  0x00007fa2e103dc3f g_variant_new_byte (libglib-2.0.so.0)
                                              #4  0x00007fa2e10432f1 n/a (libglib-2.0.so.0)
                                              #5  0x00007fa2e104312b n/a (libglib-2.0.so.0)
                                              #6  0x00007fa2e10435c2 g_variant_new_va (libglib-2.0.so.0)
                                              #7  0x00007fa2e1043dbd g_variant_builder_add (libglib-2.0.so.0)
                                              #8  0x00007fa2e18062ab g_dbus_message_to_blob (libgio-2.0.so.0)
                                              #9  0x00007fa2e17faa6d n/a (libgio-2.0.so.0)
                                              #10 0x00007fa2e17fce55 n/a (libgio-2.0.so.0)
                                              #11 0x00007fa2e1800fa7 g_dbus_connection_signal_unsubscribe (libgio-2.0.so.0)
                                              #12 0x00007fa2e180a959 n/a (libgio-2.0.so.0)
                                              #13 0x00007fa2e12e2e0a g_object_unref (libgobject-2.0.so.0)
                                              #14 0x00007fa2e0ff825a n/a (libglib-2.0.so.0)
                                              #15 0x00007fa2e0ff91a3 g_hash_table_remove_all (libglib-2.0.so.0)
                                              #16 0x00007fa2e0ff91de g_hash_table_destroy (libglib-2.0.so.0)
                                              #17 0x00007fa2dec6eeee n/a (libsecret-1.so.0)
                                              #18 0x00007fa2e17a0b18 n/a (libgio-2.0.so.0)
                                              #19 0x00007fa2e12e2e0a g_object_unref (libgobject-2.0.so.0)
                                              #20 0x00007fa2dec70169 n/a (libsecret-1.so.0)
                                              #21 0x00007fa2e17b2413 n/a (libgio-2.0.so.0)
                                              #22 0x00007fa2e17b2abe n/a (libgio-2.0.so.0)
                                              #23 0x00007fa2e180aa1b n/a (libgio-2.0.so.0)
                                              #24 0x00007fa2e17b2413 n/a (libgio-2.0.so.0)
                                              #25 0x00007fa2e17b2abe n/a (libgio-2.0.so.0)
                                              #26 0x00007fa2e17ff54a n/a (libgio-2.0.so.0)
                                              #27 0x00007fa2e17b2413 n/a (libgio-2.0.so.0)
                                              #28 0x00007fa2e17b2449 n/a (libgio-2.0.so.0)
                                              #29 0x00007fa2e1009c7a g_main_context_dispatch (libglib-2.0.so.0)
                                              #30 0x00007fa2e100a020 n/a (libglib-2.0.so.0)
                                              #31 0x00007fa2e100a342 g_main_loop_run (libglib-2.0.so.0)
                                              #32 0x00007fa2e29adafc meta_run (libmutter.so.0)
                                              #33 0x00000000004021a7 main (gnome-shell)
                                              #34 0x00007fa2e0a1f610 __libc_start_main (libc.so.6)
                                              #35 0x00000000004022d9 n/a (gnome-shell)
                                              
                                              Stack trace of thread 2098:
                                              #0  0x00007fa2e0ae3cf9 syscall (libc.so.6)
                                              #1  0x00007fa2e104e87a g_cond_wait_until (libglib-2.0.so.0)
                                              #2  0x00007fa2e0fdea69 n/a (libglib-2.0.so.0)
                                              #3  0x00007fa2e1031086 n/a (libglib-2.0.so.0)
                                              #4  0x00007fa2e1030715 n/a (libglib-2.0.so.0)
                                              #5  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #6  0x00007fa2e0ae813d __clone (libc.so.6)
                                              
                                              Stack trace of thread 832:
                                              #0  0x00007fa2e0db007f pthread_cond_wait@@GLIBC_2.3.2 (libpthread.so.0)
                                              #1  0x00007fa2d34f94b0 PR_WaitCondVar (libnspr4.so)
                                              #2  0x00007fa2dc8bbe9e n/a (libmozjs-24.so)
                                              #3  0x00007fa2d34fed7b n/a (libnspr4.so)
                                              #4  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #5  0x00007fa2e0ae813d __clone (libc.so.6)
                                              
                                              Stack trace of thread 833:
                                              #0  0x00007fa2e0db007f pthread_cond_wait@@GLIBC_2.3.2 (libpthread.so.0)
                                              #1  0x00007fa2d34f94b0 PR_WaitCondVar (libnspr4.so)
                                              #2  0x00007fa2dc92f816 n/a (libmozjs-24.so)
                                              #3  0x00007fa2d34fed7b n/a (libnspr4.so)
                                              #4  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #5  0x00007fa2e0ae813d __clone (libc.so.6)
                                              
                                              Stack trace of thread 816:
                                              #0  0x00007fa2e0adf18d poll (libc.so.6)
                                              #1  0x00007fa2e1009fbc n/a (libglib-2.0.so.0)
                                              #2  0x00007fa2e100a0cc g_main_context_iteration (libglib-2.0.so.0)
                                              #3  0x00007fa2e100a109 n/a (libglib-2.0.so.0)
                                              #4  0x00007fa2e1030715 n/a (libglib-2.0.so.0)
                                              #5  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #6  0x00007fa2e0ae813d __clone (libc.so.6)
                                              
                                              Stack trace of thread 828:
                                              #0  0x00007fa2e0adf18d poll (libc.so.6)
                                              #1  0x00007fa2e1009fbc n/a (libglib-2.0.so.0)
                                              #2  0x00007fa2e100a0cc g_main_context_iteration (libglib-2.0.so.0)
                                              #3  0x00007fa2c6df825d n/a (libdconfsettings.so)
                                              #4  0x00007fa2e1030715 n/a (libglib-2.0.so.0)
                                              #5  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #6  0x00007fa2e0ae813d __clone (libc.so.6)
                                              
                                              Stack trace of thread 831:
                                              #0  0x00007fa2e0adf18d poll (libc.so.6)
                                              #1  0x00007fa2dce68f51 n/a (libpulse.so.0)
                                              #2  0x00007fa2dce5a571 pa_mainloop_poll (libpulse.so.0)
                                              #3  0x00007fa2dce5ac0e pa_mainloop_iterate (libpulse.so.0)
                                              #4  0x00007fa2dce5acc0 pa_mainloop_run (libpulse.so.0)
                                              #5  0x00007fa2dce68ee6 n/a (libpulse.so.0)
                                              #6  0x00007fa2d1f895f8 n/a (libpulsecommon-7.1.so)
                                              #7  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #8  0x00007fa2e0ae813d __clone (libc.so.6)
                                              
                                              Stack trace of thread 2099:
                                              #0  0x00007fa2e0ae3cf9 syscall (libc.so.6)
                                              #1  0x00007fa2e104e87a g_cond_wait_until (libglib-2.0.so.0)
                                              #2  0x00007fa2e0fdea69 n/a (libglib-2.0.so.0)
                                              #3  0x00007fa2e1031086 n/a (libglib-2.0.so.0)
                                              #4  0x00007fa2e1030715 n/a (libglib-2.0.so.0)
                                              #5  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #6  0x00007fa2e0ae813d __clone (libc.so.6)
                                              
                                              Stack trace of thread 820:
                                              #0  0x00007fa2e0adf18d poll (libc.so.6)
                                              #1  0x00007fa2e1009fbc n/a (libglib-2.0.so.0)
                                              #2  0x00007fa2e100a342 g_main_loop_run (libglib-2.0.so.0)
                                              #3  0x00007fa2e180d236 n/a (libgio-2.0.so.0)
                                              #4  0x00007fa2e1030715 n/a (libglib-2.0.so.0)
                                              #5  0x00007fa2e0daa4a4 start_thread (libpthread.so.0)
                                              #6  0x00007fa2e0ae813d __clone (libc.so.6)
Comment 4 Rui Matos 2016-01-21 12:19:34 UTC
Can one of you try this patch https://git.gnome.org/browse/gnome-shell/commit/?id=021cecbce289f1d9c68a156d5b8dd204a73bc715 ?
Comment 5 wwn 2016-01-21 12:41:44 UTC
(In reply to Rui Matos from comment #4)
> Can one of you try this patch
> https://git.gnome.org/browse/gnome-shell/commit/
> ?id=021cecbce289f1d9c68a156d5b8dd204a73bc715 ?

i'll do tonight. thx for yout commitment.
Comment 6 wwn 2016-01-21 15:11:07 UTC
maybe helful for you... a hint from the Arch Linux Forum:

Member "Core" wrote:
"If anyone needs a temporary solution:
# sudo pacman -U /var/cache/pacman/pkg/libsecret-0.18.3-1-x86_64.pkg.tar.xz
everything is working fine after downgrading this (and restarting services)."
Comment 7 Phillip Schichtel 2016-01-23 21:29:57 UTC
(In reply to Rui Matos from comment #4)
> Can one of you try this patch
> https://git.gnome.org/browse/gnome-shell/commit/
> ?id=021cecbce289f1d9c68a156d5b8dd204a73bc715 ?

I tried the patch and it didn't crash with it.
Comment 8 wwn 2016-01-24 08:53:43 UTC
(In reply to Phillip Schichtel from comment #7)

> I tried the patch and it didn't crash with it.

I can canfirm that. Thank you.
Comment 9 Alexandre Franke 2017-11-02 22:07:54 UTC
Rui, was the patch committed? RESOLVED FIXED?
Comment 10 Florian Müllner 2017-11-02 22:19:42 UTC
Yes, the link points to the commit log.
Comment 11 Alexandre Franke 2017-11-02 22:39:30 UTC
(In reply to Florian Müllner from comment #10)
> Yes, the link points to the commit log.

Silly me. Indeed it does. Sorry.
Comment 12 Florian Müllner 2017-11-02 22:59:45 UTC
(In reply to Alexandre Franke from comment #11)
> Silly me. Indeed it does. Sorry.

Sorry for doing triaging gnome-shell bugs? Seriously, you shouldn't apologize, you should name the beverage of your choice!