After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760900 - libmenu: Remove support for legacy-dirs
libmenu: Remove support for legacy-dirs
Status: RESOLVED FIXED
Product: gnome-menus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-menus dummy account
gnome-menus dummy account
Depends on:
Blocks:
 
 
Reported: 2016-01-20 19:17 UTC by Florian Müllner
Modified: 2016-05-23 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libmenu: Remove support for legacy-dirs (16.48 KB, patch)
2016-01-20 19:17 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-01-20 19:17:13 UTC 
See patch.

Those directories are already ignored in a regular GNOME session, and the disagreement between GIO and GMenu about what applications are available is causing trouble for the apps-menu extension (see bug 759004). Removing the support after over ten years of deprecation seems fair enough ...
Comment 1 Florian Müllner 2016-01-20 19:17:19 UTC 
Created attachment 319455 [details] [review]
libmenu: Remove support for legacy-dirs

Those directories have been deprecated for over a decade and GIO's
GDesktopAppInfo API already ignores them ...
It's time to let go, simply ignore any <LegacyKDEDirs> and <LegacyDir>
elements in menus.
Comment 2 Jasper St. Pierre (not reading bugmail) 2016-01-20 19:52:00 UTC 
Review of attachment 319455 [details] [review]:

OK.
Comment 3 Florian Müllner 2016-01-21 15:48:43 UTC 
Attachment 319455 [details] pushed as 13c6790 - libmenu: Remove support for legacy-dirs
Comment 4 Laurent Bigonville 2016-05-23 15:24:11 UTC 
Isn't this still part of the xdg menu specification?
Comment 5 Florian Müllner 2016-05-23 15:44:51 UTC 
Yes, which is why the parser still accepts them as valid input. But after being deprecated for 13 years, expecting people to not rely on them seems fair enough to me. In particular as other parts of the platform have been ignoring them for years - the file manager's "Open with ..." menu, GTK+'s application picker, gnome-shell's app view and other bits have ignore legacy dirs for a long time or never supported them in the first place.