After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760889 - Add way to show/hide loaded custom layers
Add way to show/hide loaded custom layers
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-20 14:30 UTC by Hashem Nasarat
Modified: 2016-01-30 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eye icon (2.86 KB, image/svg+xml)
2016-01-25 12:02 UTC, Andreas Nilsson
  Details
visibility off icon (3.17 KB, image/svg+xml)
2016-01-26 12:59 UTC, Andreas Nilsson
  Details
Cast of using the eye (1.21 MB, video/webm)
2016-01-29 16:54 UTC, Jonas Danielsson
  Details
Add a way to toggle visibility of a shape layer (4.70 KB, patch)
2016-01-29 16:58 UTC, Jonas Danielsson
none Details | Review
Add a way to toggle visibility of a shape layer (11.81 KB, patch)
2016-01-29 16:58 UTC, Jonas Danielsson
committed Details | Review
layer-visible (3.97 KB, image/svg+xml)
2016-01-29 23:43 UTC, Andreas Nilsson
  Details
layber-not-visible (5.19 KB, image/svg+xml)
2016-01-29 23:44 UTC, Andreas Nilsson
  Details

Description Hashem Nasarat 2016-01-20 14:30:22 UTC
It'd be nice to allow the user to toggle which loaded layers are currently displayed on the map.
Comment 1 Andreas Nilsson 2016-01-20 14:37:32 UTC
As I mentioned on IRC, I think checkboxes might be easiest and most straight forward.
So something like this:

 ________/\__________
|                     |
|                     |
|                     |
|_____________________|
|                     |
|                     |
|                     |
|_____________________|
|                     |
| [✓] nameoflayer [x] |
| [✓] nameoflayer [x] |
| [ ] nameoflayer [x] |
| [ ] nameoflayer [x] |
| (  Load Map Layer ) |
|_____________________|
Comment 2 Andreas Nilsson 2016-01-20 14:46:27 UTC
Open question from IRC:
<jonasdn> andreasn: hashem should tge default action of arow be toggle show or go to layer?
Comment 3 Andreas Nilsson 2016-01-25 12:02:02 UTC
Created attachment 319676 [details]
eye icon
Comment 4 Andreas Nilsson 2016-01-25 12:05:38 UTC
I've gone over this in my head on and off the last couple of days, and I think my conclusion so far is that the checkboxes is a dead end, since labels of checkboxes always acts on the checkboxes.
I've added the eye instead. Lets use that as originally planned. It would go to the very left. It will also need an off state.
Comment 5 Andreas Nilsson 2016-01-26 12:59:13 UTC
Created attachment 319746 [details]
visibility off icon
Comment 6 Jonas Danielsson 2016-01-29 16:54:26 UTC
Created attachment 320023 [details]
Cast of using the eye

So it looks like this, what do you think? There seem to be a rendering bug with the eye though? It looks fine in firefox for me, but renders like that in Maps.

Question should the button be circular?
Comment 7 Andreas Nilsson 2016-01-29 16:57:26 UTC
(In reply to Jonas Danielsson from comment #6)
> Created attachment 320023 [details]
> Cast of using the eye
> 
> So it looks like this, what do you think? There seem to be a rendering bug
> with the eye though? It looks fine in firefox for me, but renders like that
> in Maps.

It might be due to path vs objects. I can get you a new image that tries to fix that.

> 
> Question should the button be circular?

I think it looks out of place circular. I filed a bug about the close icon being circular recently, but I forgot the number.
Comment 8 Jonas Danielsson 2016-01-29 16:58:05 UTC
Created attachment 320024 [details] [review]
Add a way to toggle visibility of a shape layer

Add an eye shaped button that toggles the visiblity of a
shape layer in the layers popover.
Comment 9 Jonas Danielsson 2016-01-29 16:58:48 UTC
Created attachment 320025 [details] [review]
Add a way to toggle visibility of a shape layer

Add an eye shaped button that toggles the visiblity of a
shape layer in the layers popover.
Comment 10 Andreas Nilsson 2016-01-29 23:43:42 UTC
Created attachment 320046 [details]
layer-visible

Updated icon to fix the gray fill issue
Comment 11 Andreas Nilsson 2016-01-29 23:44:20 UTC
Created attachment 320047 [details]
layber-not-visible

Fixes the gray fill issue
Comment 12 Andreas Nilsson 2016-01-29 23:44:47 UTC
These two icons above should fix the issue
Comment 13 Jonas Danielsson 2016-01-30 10:36:46 UTC
Attachment 320025 [details] pushed as e1ac6f7 - Add a way to toggle visibility of a shape layer