After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760875 - Small issues with layers popover
Small issues with layers popover
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on: 759544
Blocks:
 
 
Reported: 2016-01-20 06:05 UTC by Hashem Nasarat
Modified: 2016-01-22 01:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
LayersPopover: set frame using css not GtkFrame (2.94 KB, patch)
2016-01-20 06:05 UTC, Hashem Nasarat 		committed Details | Review
Layers: Don't hide popover if user cancels FileChooser (1.11 KB, patch)
2016-01-20 06:05 UTC, Hashem Nasarat 		committed Details | Review
MapView: Remove unused gettext import (875 bytes, patch)
2016-01-20 06:05 UTC, Hashem Nasarat 		committed Details | Review

Description Hashem Nasarat 2016-01-20 06:05:32 UTC 
I caught/fixed these after the main patch was merged.
Comment 1 Hashem Nasarat 2016-01-20 06:05:35 UTC 
Created attachment 319403 [details] [review]
LayersPopover: set frame using css not GtkFrame

GtkFrame in 3.19 has bug 760482 where it cuts off the bottom 2 pixels of
its child. Setting the frame using the same styling as GtkFrame gets us
the desired look with all our pixels intact.
Comment 2 Hashem Nasarat 2016-01-20 06:05:41 UTC 
Created attachment 319404 [details] [review]
Layers: Don't hide popover if user cancels FileChooser

If the user accidentally clicks on "Open Layer" and then cancels the
FileChooserDialog, we should bring them back to the expected state of
having the popover visible.
Comment 3 Hashem Nasarat 2016-01-20 06:05:45 UTC 
Created attachment 319405 [details] [review]
MapView: Remove unused gettext import

This was accidentally added in one of the iterations of 37e8ac44d and
was never removed after it was no longer needed.
Comment 4 Jonas Danielsson 2016-01-20 06:10:06 UTC 
Review of attachment 319403 [details] [review]:

Thanks!

Is this also better in some way? Or is this hackier? If it is hackier we should just wait for the bug to be fixed. The 3.20 release is some way off still.
Comment 5 Jonas Danielsson 2016-01-20 06:10:33 UTC 
Review of attachment 319404 [details] [review]:

Ok!
Comment 6 Jonas Danielsson 2016-01-20 06:10:48 UTC 
Review of attachment 319405 [details] [review]:

Thanks!
Comment 7 Hashem Nasarat 2016-01-20 06:13:44 UTC 
Review of attachment 319403 [details] [review]:

Matthias suggested we have the listbox display its own frame. I get the feeling they're moving in the direction of deprecating GtkFrame.
Comment 8 Jonas Danielsson 2016-01-20 06:17:53 UTC 
Review of attachment 319403 [details] [review]:

Great!
Comment 9 Hashem Nasarat 2016-01-22 01:26:04 UTC 
Attachment 319403 [details] pushed as acdff80 - LayersPopover: set frame using css not GtkFrame
Attachment 319404 [details] pushed as 14521b7 - Layers: Don't hide popover if user cancels FileChooser
Attachment 319405 [details] pushed as 886d7ea - MapView: Remove unused gettext import