After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760869 - Buttons in the action bar should be always visible
Buttons in the action bar should be always visible
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.18.x
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-20 00:55 UTC by Alessandro Bono
Modified: 2016-02-12 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
installed: Set insensitive instead of hide action bar's buttons (3.27 KB, patch)
2016-01-20 00:59 UTC, Alessandro Bono 		none Details | Review
installed: Remove buttons' margin (1.68 KB, patch)
2016-01-20 00:59 UTC, Alessandro Bono 		none Details | Review
installed: Remove button_folder_fake (1.34 KB, patch)
2016-01-20 00:59 UTC, Alessandro Bono 		none Details | Review

Description Alessandro Bono 2016-01-20 00:55:43 UTC 
Then the selection mode is activated the action bar is empty until something is selected. In Documents, Photos and Videos the buttons are always visible but insensitive when necessary.
Comment 1 Alessandro Bono 2016-01-20 00:59:01 UTC 
Created attachment 319392 [details] [review]
installed: Set insensitive instead of hide action bar's buttons
Comment 2 Alessandro Bono 2016-01-20 00:59:07 UTC 
Created attachment 319393 [details] [review]
installed: Remove buttons' margin
Comment 3 Alessandro Bono 2016-01-20 00:59:12 UTC 
Created attachment 319394 [details] [review]
installed: Remove button_folder_fake

Since button are always visible it isn't needed anymore
Comment 4 Rafal Luzynski 2016-01-21 20:40:58 UTC 
Technically looks correct but have you consulted this idea with Allan and/or other designers?

(In reply to Alessandro Bono from comment #2)
> Created attachment 319393 [details] [review] [review]
> installed: Remove buttons' margin

Especially this one?
Comment 5 Allan Day 2016-02-09 20:06:31 UTC 
I've tested the patches and this all looks good to me. From my tests, it looks like the margin patch removes padding from between the buttons - which is actually an improvement from what I can see.

Let me know if I'm misinterpreting, though.
Comment 6 Rafal Luzynski 2016-02-09 22:15:37 UTC 
Thanks, Allan, I just wanted to make sure you accept these patches and the visual/UI/UX changes they introduce. You understood my question correctly.

As I said in comment 4, I also cannot see any technical issues but the patches must be also checked by the g-s authors.
Comment 7 Richard Hughes 2016-02-12 12:46:54 UTC 
All applied, thanks all!