After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760864 - Don't use deprecated pseudo classes in css
Don't use deprecated pseudo classes in css
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-19 21:22 UTC by Matthias Clasen
Modified: 2016-01-20 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't use deprecated pseudo classes in css (1.91 KB, patch)
2016-01-19 21:23 UTC, Matthias Clasen 		accepted-commit_now Details | Review

Description Matthias Clasen 2016-01-19 21:22:59 UTC 
The :prelight pseudo class has been deprecated in favor of :hover.
Comment 1 Matthias Clasen 2016-01-19 21:23:02 UTC 
Created attachment 319384 [details] [review]
Don't use deprecated pseudo classes in css
Comment 2 Lasse Schuirmann 2016-01-19 21:35:04 UTC 
Review of attachment 319384 [details] [review]:

I'd use something like "css: Use :hover instead of :prelight (deprecated)" as shortlog since it describes the change and not what not to use.

Last word goes to pbor of course.
Comment 3 Paolo Borelli 2016-01-19 22:47:06 UTC 
Review of attachment 319384 [details] [review]:

I thought I was picky, but the new generation is surpassing me :-)

Patch looks good, if you want to reword the commit with Lasse's suggestion it is ok, but it is not strictly necessary.
Comment 4 Lasse Schuirmann 2016-01-19 23:02:53 UTC 
(In reply to Paolo Borelli from comment #3)
> Review of attachment 319384 [details] [review] [review]:
> 
> I thought I was picky, but the new generation is surpassing me :-)
> 
> Patch looks good, if you want to reword the commit with Lasse's suggestion
> it is ok, but it is not strictly necessary.

I was mentored by zeeshan ;)