After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760847 - EDS plugin should be embedded in To Do app
EDS plugin should be embedded in To Do app
Product: gnome-todo
Classification: Other
Component: General
Other Linux
: High enhancement
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Reported: 2016-01-19 15:32 UTC by Georges Basile Stavracas Neto
Modified: 2016-04-21 23:48 UTC
See Also:
GNOME target: ---
GNOME version: 3.19/3.20

Patch to make eds an embedded plugin (6.89 KB, patch)
2016-03-02 19:25 UTC, Saiful B. Khan
reviewed Details | Review
Second Patch for embedding eds (6.86 KB, patch)
2016-03-02 20:22 UTC, Saiful B. Khan
committed Details | Review
eds: clang does not support -u compiler option (988 bytes, patch)
2016-04-21 17:54 UTC, Ting-Wei Lan
committed Details | Review

Description Georges Basile Stavracas Neto 2016-01-19 15:32:19 UTC
Libpeas added support for embedded plugins since version 0.17. Since the EDS plugin is the default, and is hidden for the user, it should be embedded into To Do.
Comment 1 Saiful B. Khan 2016-03-02 19:25:41 UTC
Created attachment 322911 [details] [review]
Patch to make eds an embedded plugin

First Patch.
Please notify if any changes are necessary.
Comment 2 Georges Basile Stavracas Neto 2016-03-02 19:46:42 UTC
Review of attachment 322911 [details] [review]:

One nitpick only.

::: data/todo.gresource.xml
@@ +26,3 @@
+  </gresource>
+  <gresource prefix="/org/gnome/todo/plugins/eds">
+    <file alias="eds.plugin">../plugins/eds/eds.plugin</file>

I'd prefer that you put it like this:

<!-- EDS plugin -->
<gresource prefix="/org/gnome/todo">
  <file compressed="true" alias="blabla">bla.ui</file>
  <file compressed="true" alias="blabla">bla.plugin</file>

It is all groups in one section, commented so I can always remember this is related to EDS plugin.
Comment 3 Saiful B. Khan 2016-03-02 20:22:17 UTC
Created attachment 322918 [details] [review]
Second Patch for embedding eds

Georges, thanks for reviewing the earlier patch. Please verify if the changes made are desired.
Comment 4 Georges Basile Stavracas Neto 2016-03-02 21:13:31 UTC
Thanks for working on it.
Comment 5 Ting-Wei Lan 2016-03-09 19:24:22 UTC
It seems that clang doesn't know the -u option ...

  CCLD     gnome-todo
clang: error: argument unused during compilation: '-u gtd_plugin_eds_register_types'
Comment 6 Georges Basile Stavracas Neto 2016-03-09 20:03:50 UTC
Is there any replacement for this argument on Clang side?
Comment 7 Ting-Wei Lan 2016-04-21 17:54:43 UTC
Created attachment 326514 [details] [review]
eds: clang does not support -u compiler option

It seems gcc simply passes the -u option to the linker, so this commit
replaces the compiler option with the linker option, which fix the build
or runtime problem when compiling with clang. To keep consistent with
existing LDFLAGS, the long option is used instead of the short option.
Comment 8 Georges Basile Stavracas Neto 2016-04-21 23:48:48 UTC

Attachment 326514 [details] pushed as 4238eb6 - eds: clang does not support -u compiler option