GNOME Bugzilla – Bug 760847
EDS plugin should be embedded in To Do app
Last modified: 2016-04-21 23:48:52 UTC
Libpeas added support for embedded plugins since version 0.17. Since the EDS plugin is the default, and is hidden for the user, it should be embedded into To Do.
Created attachment 322911 [details] [review]
Patch to make eds an embedded plugin
Please notify if any changes are necessary.
Review of attachment 322911 [details] [review]:
One nitpick only.
@@ +26,3 @@
+ <gresource prefix="/org/gnome/todo/plugins/eds">
+ <file alias="eds.plugin">../plugins/eds/eds.plugin</file>
I'd prefer that you put it like this:
<!-- EDS plugin -->
<file compressed="true" alias="blabla">bla.ui</file>
<file compressed="true" alias="blabla">bla.plugin</file>
It is all groups in one section, commented so I can always remember this is related to EDS plugin.
Created attachment 322918 [details] [review]
Second Patch for embedding eds
Georges, thanks for reviewing the earlier patch. Please verify if the changes made are desired.
Thanks for working on it.
It seems that clang doesn't know the -u option ...
clang: error: argument unused during compilation: '-u gtd_plugin_eds_register_types'
Is there any replacement for this argument on Clang side?
Created attachment 326514 [details] [review]
eds: clang does not support -u compiler option
It seems gcc simply passes the -u option to the linker, so this commit
replaces the compiler option with the linker option, which fix the build
or runtime problem when compiling with clang. To keep consistent with
existing LDFLAGS, the long option is used instead of the short option.
Attachment 326514 [details] pushed as 4238eb6 - eds: clang does not support -u compiler option