After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760842 - chatView: whitespace next to compressed status message is clickable
chatView: whitespace next to compressed status message is clickable
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-19 14:23 UTC by Bastian Ilsø
Modified: 2016-02-10 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot showing mouse hover on the white space next to status message (14.98 KB, image/png)
2016-01-19 14:23 UTC, Bastian Ilsø
  Details
chatView: Don't extend interactive tags into margins (1.89 KB, patch)
2016-02-10 16:03 UTC, Florian Müllner
committed Details | Review

Description Bastian Ilsø 2016-01-19 14:23:43 UTC
Created attachment 319355 [details]
screenshot showing mouse hover on the white space next to status message

Status messages are react to hover and are clickable outside the text itself. This can be prone to mis-clicking and is a bit confusing behavior.

My guess to the reason is that the newline character we insert before inserting the "6 users joined, 4 users left" text is tagged with a style tag that causes this behavior.
Comment 1 Florian Müllner 2016-01-20 14:26:49 UTC
(In reply to Bastian Ilsø from comment #0)
> My guess to the reason is that the newline character we insert before
> inserting the "6 users joined, 4 users left" text is tagged with a style tag
> that causes this behavior.

I think it's just the justification to the right - in any case, the newline has to be part of the tag to not show it when the status line is hidden.
Comment 2 Florian Müllner 2016-02-10 16:03:29 UTC
The following fix has been pushed:
15dc959 chatView: Don't extend interactive tags into margins
Comment 3 Florian Müllner 2016-02-10 16:03:35 UTC
Created attachment 320805 [details] [review]
chatView: Don't extend interactive tags into margins

Until now, margins neighboring interactive elements like links or
status headers have been clickable as well. GTK+ now gives us API
to check whether a position is over text, so use that to fix the
issue.