After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760827 - gegl:shear can lead to segfaults when built with clang
gegl:shear can lead to segfaults when built with clang
Status: RESOLVED OBSOLETE
Product: GEGL
Classification: Other
Component: operations
git master
Other Linux
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2016-01-19 11:32 UTC by Massimo
Modified: 2018-05-22 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Massimo 2016-01-19 11:32:41 UTC
This becomes a problem because during make, gegl-tester
is run with default values and at least when building
with CC=clang it seg faults:

/bin/sh: line 6: 16779 Segmentation fault      GEGL_SWAP=RAM GEGL_PATH=../operations ../bin/gegl-tester --all -o images/examples -d ...
Makefile:775: recipe for target 'examples' failed
make[2]: *** [examples] Error 139


See:

https://git.gnome.org/browse/gegl/tree/operations/transform/shear.c#n25
 
the matrix
 
 1 1 0
 1 1 0
 0 0 1

is singular and not invertible, affine_transform tries to invert it,
it results in nans that then fail every comparison and samplers
are given invalid pointers...


BTW setting both x and y gegl:shear properties != 0 does not result in
a pure shear transform. For example x=1 and y=-1 would be a 45° rotation
combined with a scale.

Anyway the default has to be changed or a reference composition
should be added to this op or this operation should be excluded
from the generation of example images
Comment 1 Øyvind Kolås (pippin) 2016-02-15 21:02:42 UTC
commit 19d71edfbb37fe86097dce910711ca1151775ac2
Author: Øyvind Kolås <pippin@gimp.org>
Date:   Mon Feb 15 21:47:10 2016 +0100

    gegl:shear default to no shearing
    
    This mitigates bug https://bugzilla.gnome.org/show_bug.cgi?id=760827 , though
    by setting both X and Y to non-0.0 values, clang based compiles would still
    segfault
Comment 2 GNOME Infrastructure Team 2018-05-22 12:12:18 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gegl/issues/32.