After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760826 - Evince previewer shouldn't try to print to NULL printer
Evince previewer shouldn't try to print to NULL printer
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: printing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Felipe Borges
Evince Maintainers
: 763695 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-01-19 10:52 UTC by Marek Kašík
Modified: 2018-05-22 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
previewer: set print button sensitivity according to print-settings (993 bytes, patch)
2016-03-23 15:20 UTC, Felipe Borges
none Details | Review

Description Marek Kašík 2016-01-19 10:52:08 UTC
When user clicks on print button in evince-previewer when it is called without specification of print settings file it shows warning that "The selected printer '(null)' could not be found".

Maybe a better solution would be to make the print button insensitive if there is no print settings file specified.

Would you accept a patch for this?
Comment 1 Germán Poo-Caamaño 2016-01-19 15:17:45 UTC
It makes sense.
Comment 2 Felipe Borges 2016-03-23 14:37:46 UTC
*** Bug 763695 has been marked as a duplicate of this bug. ***
Comment 3 Felipe Borges 2016-03-23 15:20:49 UTC
Created attachment 324595 [details] [review]
previewer: set print button sensitivity according to print-settings
Comment 4 Carlos Garcia Campos 2016-04-10 08:17:04 UTC
Actually, the idea was that when not settings file was given, the default printer was used. The problem in this case seems to be that there's no printers at all and we are not handling that case. So I think the right solution would be in ev_previewer_window_enumerate_finished when the printer is NULL, check if gtk_print_settings_get_printer is also NULL and in that case show a different message saying that default printer could not be found, or something like that. Or we could detect that situation to disable the print button, but that would require to enumerate printers at startup, even if you are not going to print at all, so I don't think it's worth it.
Comment 5 Carlos Garcia Campos 2016-04-10 08:18:04 UTC
Note that the bug title is confusing, because evince doesn't try to print to NULL printer, that case is handled, it's only the error message what is wrong.
Comment 6 GNOME Infrastructure Team 2018-05-22 16:28:25 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/645.