After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760760 - Black bottom border in export dialog preview
Black bottom border in export dialog preview
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-17 22:40 UTC by Damián Nohales
Modified: 2016-01-18 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (42.27 KB, image/png)
2016-01-17 22:40 UTC, Damián Nohales 		  Details
exportDialog: Don't expand preview vertically (1.29 KB, patch)
2016-01-17 22:54 UTC, Damián Nohales 		committed Details | Review
exportDialog: Make the dialog non-resizable (1010 bytes, patch)
2016-01-17 23:00 UTC, Damián Nohales 		committed Details | Review

Description Damián Nohales 2016-01-17 22:40:12 UTC 
Created attachment 319229 [details]
screenshot

If you make the export dialog vertically larger, an ugly black space is drawn in the screen.

The screenshot attached shows the problem, well, the black space is represented as a transparent space in the PNG file.
Comment 1 Damián Nohales 2016-01-17 22:54:54 UTC 
Created attachment 319230 [details] [review]
exportDialog: Don't expand preview vertically

The export dialog drawing area was expanded vertically due to
resize policy of the GtkAlignment parent, in those cases, we
were drawing just a section of the drawing area, the undrawed
section was shown with an ugly black background.
Comment 2 Damián Nohales 2016-01-17 23:00:10 UTC 
Created attachment 319231 [details] [review]
exportDialog: Make the dialog non-resizable

This is not the kind of dialog we want to make resizable.
The widgets layout is not designed to be expanded.
Comment 3 Jonas Danielsson 2016-01-18 06:40:22 UTC 
Nice bug number
Comment 4 Jonas Danielsson 2016-01-18 06:43:08 UTC 
Review of attachment 319230 [details] [review]:

Thanks Damián!
Comment 5 Jonas Danielsson 2016-01-18 06:43:23 UTC 
Review of attachment 319231 [details] [review]:

Agreed \o/
Comment 6 Jonas Danielsson 2016-01-18 17:18:07 UTC 
Attachment 319230 [details] pushed as 8cdde93 - exportDialog: Don't expand preview vertically
Attachment 319231 [details] pushed as a41b0d6 - exportDialog: Make the dialog non-resizable