After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760752 - doap: do not use ide_str methods
doap: do not use ide_str methods
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-17 20:06 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2016-02-21 23:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
doap: do not use ide_str methods (6.18 KB, patch)
2016-01-17 20:06 UTC, Ignacio Casal Quinteiro (nacho) 		committed Details | Review
Move doap code to contrib/doap (11.86 KB, patch)
2016-01-20 07:21 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review

Description Ignacio Casal Quinteiro (nacho) 2016-01-17 20:06:25 UTC 
This is so it is easier to copy & paste into other projects like
gitg keeping builder as the main repository
Comment 1 Ignacio Casal Quinteiro (nacho) 2016-01-17 20:06:33 UTC 
Created attachment 319226 [details] [review]
doap: do not use ide_str methods
Comment 2 Ignacio Casal Quinteiro (nacho) 2016-01-17 20:07:45 UTC 
At this point, now that it is self contained, should we put it somewhere else than libide?
Comment 3 Christian Hergert 2016-01-17 21:09:33 UTC 
Review of attachment 319226 [details] [review]:

LGTM
Comment 4 Christian Hergert 2016-01-17 21:10:07 UTC 
I guess we could move to contrib/doap and build a private libdoap.la
Comment 5 Ignacio Casal Quinteiro (nacho) 2016-01-17 21:11:45 UTC 
Comment on attachment 319226 [details] [review]
doap: do not use ide_str methods

Attachment 319226 [details] pushed as 04f08b0 - doap: do not use ide_str methods
Comment 6 Ignacio Casal Quinteiro (nacho) 2016-01-17 21:13:33 UTC 
(In reply to Christian Hergert from comment #4)
> I guess we could move to contrib/doap and build a private libdoap.la

Sounds good to me, I'll provide a patch for that hopefully tomorrow.
Comment 7 Ignacio Casal Quinteiro (nacho) 2016-01-18 16:54:10 UTC 
wip/nacho/doap-contrib contains the patches for the movement and renaming.
Comment 8 Ignacio Casal Quinteiro (nacho) 2016-01-20 07:21:54 UTC 
Created attachment 319408 [details] [review]
Move doap code to contrib/doap
Comment 9 Christian Hergert 2016-01-20 17:48:09 UTC 
Review of attachment 319408 [details] [review]:

Hrmm, I need to think about this more. I don't like that all the libraries to have to manually link against the static library. It looks like we expose IdeDoap from IdeProjectInfo. We could at minimum link it into libide, which would make it accessable to consumers. But in that case, is there much difference in moving it to contrib/ as compared to libide/doap/?

Do you have any concerns consuming this code from other projects and it having an ide- prefix? Should we be making a proper libdoap?
Comment 10 Ignacio Casal Quinteiro (nacho) 2016-01-20 18:11:30 UTC 
I agree about this, either keep it as it is or to create a libdoap but that also means having to maintain it.

In any case keeping it ide_str free is already good enough for me to copy it in gitg. Thanks!