After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760748 - GtkTextView should allow hooks for reseting blink time
GtkTextView should allow hooks for reseting blink time
Product: gtk+
Classification: Platform
Component: Widget: GtkTextView
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2016-01-17 17:12 UTC by Christian Hergert
Modified: 2016-01-18 21:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

text view: Expose cursor blink control (2.02 KB, patch)
2016-01-18 19:57 UTC, Matthias Clasen
committed Details | Review

Description Christian Hergert 2016-01-17 17:12:53 UTC
There is a situation I'm seeing in Vim mode in Builder, where it is possible to move the cursor while the blink is off. This makes it terribly difficult under key-repeat scenarios to quickly land on the target line.

I can make this happen with arrows, as well as j/k/l/h.

This seems to be caused by Builder having it's own extended set of movements, which do not allow for us to reset the blink time, or check/pend cursor blink.

Perhaps we should add a function for us to access this.
Comment 1 Matthias Clasen 2016-01-17 20:13:26 UTC
You need gtk_text_view_pend_cursor_blink made public, more or less ? That is what GtkTextView calls in its key-press handler to ensure the caret stays visible during keynav.
Comment 2 sébastien lafargue 2016-01-17 21:53:35 UTC
we need both



Comment 3 Matthias Clasen 2016-01-18 19:57:01 UTC
Created attachment 319302 [details] [review]
text view: Expose cursor blink control

Derived classes like GtkSourceView with their own ::key-event
handler need access to this, in order to make their keynav
as nice as the builtin one, wrt to caret visibility.

Comment 4 sébastien lafargue 2016-01-18 20:31:34 UTC
Review of attachment 319302 [details] [review]:

missmatching type between definition and declaration ( gboolean vs void)
Comment 5 Matthias Clasen 2016-01-18 21:30:18 UTC
Attachment 319302 [details] pushed as 1821c2d - text view: Expose cursor blink control