After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760739 - REGRESSION (ce0b0d0d): Tests fail after commit: "Do not print error context when there is none"
REGRESSION (ce0b0d0d): Tests fail after commit: "Do not print error context w...
Status: RESOLVED FIXED
Product: libxml2
Classification: Platform
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-17 07:34 UTC by David Kilzer
Modified: 2016-05-03 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch v1 (26.71 KB, patch)
2016-01-17 07:45 UTC, David Kilzer 		none Details | Review
error.c: *input->cur == 0 does not mean no error (796 bytes, patch)
2016-02-05 08:53 UTC, Pavel Raiskup 		none Details | Review

Description David Kilzer 2016-01-17 07:34:02 UTC 
Test results changed after commit ce0b0d0d81fdbb5f722a890432b52d363e4de57b:

https://git.gnome.org/browse/libxml2/commit/?id=ce0b0d0d81fdbb5f722a890432b52d363e4de57b

The new test failures look like this:

 ## Error cases regression tests
+754947.xml result
+6,7d5 < <d><![CDATA[0000000000000<EE>]]> < ^
+attr1.xml result
+2,3d1 < < ^
+attr2.xml result
+2,3d1 < < ^
+name.xml result
+2,3d1 < < ^
+name2.xml result
+2,3d1 < < ^
 ## Error cases stream regression tests
+attr1.xml result
+2,3d1 < < ^ 5,6d2 < < ^ 8,9d3 < < ^
+attr2.xml result
+2,3d1 < < ^ 5,6d2 < < ^ 8,9d3 < < ^
+name.xml result
+2,3d1 < < ^
+name2.xml result
+2,3d1 < < ^ 5,6d2 < < ^ 8,9d3 < < ^
Comment 1 David Kilzer 2016-01-17 07:36:40 UTC 
Note that this actually looks like a progression (and the intent of commit ce0b0d0d81fdbb5f722a890432b52d363e4de57b) since blank error messages have been removed from the expected output.
Comment 2 David Kilzer 2016-01-17 07:45:21 UTC 
Created attachment 319204 [details] [review]
Patch v1

Update test results after commit ce0b0d0d (Do not print error context when there is none).
Comment 3 David Kilzer 2016-01-21 19:10:20 UTC 
(In reply to David Kilzer from comment #2)
> Created attachment 319204 [details] [review] [review]
> Patch v1
> 
> Update test results after commit ce0b0d0d (Do not print error context when
> there is none).

Strangely, this patch causes "make check" to fail.  :(
Comment 4 Pavel Raiskup 2016-02-04 09:55:05 UTC 
This sounds like similar issue in Red Hat bugzilla.  Does the patch proposed there help?
https://bugzilla.redhat.com/show_bug.cgi?id=1286692
Comment 5 David Kilzer 2016-02-04 22:08:35 UTC 
(In reply to Pavel Raiskup from comment #4)
> This sounds like similar issue in Red Hat bugzilla.  Does the patch proposed
> there help?
> https://bugzilla.redhat.com/show_bug.cgi?id=1286692

Yes!  Your patch fixes the extra output during "make check" that I filed this bug about, and all the other tests still pass:

https://bugzilla.redhat.com/attachment.cgi?id=1100884

I think that's the correct fix here.  Could you post your patch for review on this bug?
Comment 6 David Kilzer 2016-02-04 22:09:46 UTC 
Comment on attachment 319204 [details] [review]
Patch v1

Changing the expected output is not the correct fix.

This is the correct way to fix this:
https://bugzilla.redhat.com/attachment.cgi?id=1100884
Comment 7 Pavel Raiskup 2016-02-05 08:53:00 UTC 
Created attachment 320482 [details] [review]
error.c: *input->cur == 0 does not mean no error
Comment 8 David Kilzer 2016-05-03 21:55:28 UTC 
This was fixed in c4184ba217009798504ca25f011ed7899ac1f65f:

<https://git.gnome.org/browse/libxml2/commit/?id=c4184ba217009798504ca25f011ed7899ac1f65f>