After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760682 - [PATCH] giscanner: fix tests with python3.5
[PATCH] giscanner: fix tests with python3.5
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-15 16:38 UTC by Marc-Antoine Perennou
Modified: 2016-01-18 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giscanner: fix tests with python3.5 (1.25 KB, patch)
2016-01-15 16:39 UTC, Marc-Antoine Perennou 		committed Details | Review

Description Marc-Antoine Perennou 2016-01-15 16:38:01 UTC 
GEN      Identfilter-1.0.gir
identfilter.h:7: Warning: Identfilter: identfilter_object_new: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
identfilter.h:7: Warning: Identfilter: identfilter_object_new: return value: Invalid non-constant return of bare structure or union; register as boxed type or (skip)
PASS: Identfilter-1.0.gir
  GEN      Symbolfilter-1.0.gir
Traceback (most recent call last):

+ Trace 235904

  • File "../../g-ir-scanner", line 66 in <module> 
    sys.exit(scanner_main(sys.argv))
  • File "../../giscanner/scannermain.py", line 541 in scanner_main 
    transformer.parse(ss.get_symbols())
  • File "../../giscanner/transformer.py", line 110 in parse 
    node = self._traverse_one(symbol)
  • File "../../giscanner/transformer.py", line 374 in _traverse_one 
    return self._create_function(symbol)
  • File "../../giscanner/transformer.py", line 452 in _create_function 
    name = self._strip_symbol(symbol)
  • File "../../giscanner/transformer.py", line 358 in _strip_symbol 
    (ns, name) = self.split_csymbol(ident)
  • File "../../giscanner/transformer.py", line 319 in split_csymbol 
    matches = self._split_c_string_for_namespace_matches(symbol, is_identifier=False)
  • File "../../giscanner/transformer.py", line 265 in _split_c_string_for_namespace_matches 
    name, err = proc.communicate(name)
  • File "/usr/x86_64-pc-linux-gnu/lib/python3.5/subprocess.py", line 1068 in communicate 
    stdout, stderr = self._communicate(input, endtime, timeout)
  • File "/usr/x86_64-pc-linux-gnu/lib/python3.5/subprocess.py", line 1687 in _communicate 
    input_view = memoryview(self._input)
TypeError: memoryview: a bytes-like object is required, not 'str' 
Makefile:1866: recipe for target 'Symbolfilter-1.0.gir' failed
Comment 1 Marc-Antoine Perennou 2016-01-15 16:39:30 UTC 
Created attachment 319117 [details] [review]
giscanner: fix tests with python3.5
Comment 2 Colin Walters 2016-01-18 18:31:41 UTC 
Review of attachment 319117 [details] [review]:

Hum, what changed in 3.5 here?  Well, patch looks reasonable.
Comment 3 Colin Walters 2016-01-18 18:32:59 UTC 
Attachment 319117 [details] pushed as c598d73 - giscanner: fix tests with python3.5