After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760667 - Private mode dosn't work from the app-menu
Private mode dosn't work from the app-menu
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.19.x
Other Linux
: Normal critical
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-15 11:53 UTC by Yosef Or Boczko
Modified: 2016-01-15 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: basesink: shows that basesink drops keyframes before segment (4.40 KB, patch)
2016-01-15 14:10 UTC, Thiago Sousa Santos 		rejected Details | Review
Fix crash starting incognito mode (829 bytes, patch)
2016-01-15 16:46 UTC, Michael Catanzaro 		committed Details | Review

Description Yosef Or Boczko 2016-01-15 11:53:04 UTC 
Trying to open a private-mode window from the app-menu dosn't work.

Just from the shell itself (right click on epiphany in the app-picker
and choose private window) works for me.
Comment 1 Thiago Sousa Santos 2016-01-15 14:10:19 UTC 
Created attachment 319107 [details] [review]
tests: basesink: shows that basesink drops keyframes before segment

Test that pushes a keyframe and a deltaunit before segment.start
and checks if they are preserved, otherwise the first buffers
of the stream would be useless.
Comment 2 Thiago Sousa Santos 2016-01-15 14:13:19 UTC 
Comment on attachment 319107 [details] [review]
tests: basesink: shows that basesink drops keyframes before segment

Sorry, typo in git-bz
Comment 3 Michael Catanzaro 2016-01-15 15:28:55 UTC 
It's a SIGSEGV at:

+ Trace 235902

  • #0 ephy_file_helpers_init 

And:

(gdb) print err->message
Cannot access memory at address 0x8
Comment 4 Michael Catanzaro 2016-01-15 15:53:34 UTC 
d6581d4ce8ca69821485a09c71b8d7530717c2db is the first bad commit
commit d6581d4ce8ca69821485a09c71b8d7530717c2db
Author: Michael Catanzaro <mcatanzaro@igalia.com>
Date:   Sat Dec 26 20:47:01 2015 -0600

    Enable and placate -Wno-shadow
Comment 5 Michael Catanzaro 2016-01-15 16:45:36 UTC 
Thanks for reporting this, Yosef!
Comment 6 Michael Catanzaro 2016-01-15 16:46:23 UTC 
The following fix has been pushed:
d5e6724 Fix crash starting incognito mode
Comment 7 Michael Catanzaro 2016-01-15 16:46:27 UTC 
Created attachment 319118 [details] [review]
Fix crash starting incognito mode