After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760524 - linked comboboxes change size when clicked
linked comboboxes change size when clicked
Product: gtk+
Classification: Platform
Component: Themes
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2016-01-12 13:40 UTC by Christoph Reiter (lazka)
Modified: 2016-01-16 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

screen recording (625.06 KB, image/gif)
2016-01-12 13:40 UTC, Christoph Reiter (lazka)
Theme patch (11.28 KB, patch)
2016-01-15 18:43 UTC, Lapo Calamandrei
none Details | Review

Description Christoph Reiter (lazka) 2016-01-12 13:40:49 UTC
Created attachment 318866 [details]
screen recording

Using gtk3-widget-factory when clicking the outer connected toggle buttons on page 1 the size of it changes. Afaics the connecting border is removed in the clicked state.

Screen recording attached.
Comment 1 Lapo Calamandrei 2016-01-13 00:59:52 UTC
Oh, trying to track this down I didn't notice the missing border in the active state, thanks for spotting.
Comment 2 Lapo Calamandrei 2016-01-15 18:20:50 UTC
This is just about combos tho, changing the topic accordingly.
Comment 3 Lapo Calamandrei 2016-01-15 18:25:30 UTC
This is pretty tricky and I can't find a way to fix this in the theme.
It's complicated, let me try to explain: we used to have different names in css for combos and combobox-entries, to style this without those, I was relying on the fact that in a combobox the button is always the single child. With latest changes when the button is clicked there's another child, which is the menu so, the style doesn't work anymore.
I tried rewriting the whole styling a pair of time, but of am I missing something or there's no way to fix it, hence I'd need to know when the widget is a combo or a comboboxentry.
Comment 4 Lapo Calamandrei 2016-01-15 18:43:01 UTC
Created attachment 319141 [details] [review]
Theme patch

This patch assume a combobox-entry has the .linked styleclass, which logically fits.
Comment 5 Matthias Clasen 2016-01-15 22:58:09 UTC
I've added the .linked class now to the combobox if it contains entry+button.
Comment 6 Lapo Calamandrei 2016-01-16 00:07:44 UTC
Theme fixed accordingly, closing.