After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760469 - make install fails after commit 3275ea4a29a6f938ad311ea010ed00f4037280e6
make install fails after commit 3275ea4a29a6f938ad311ea010ed00f4037280e6
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-01-11 15:04 UTC by Ben
Modified: 2016-01-11 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ben 2016-01-11 15:04:41 UTC
Commit 3275ea4a29a6f938ad311ea010ed00f4037280e6 causes make & make install to fail.  I fixed the make issue by forcing symlinking in commit fdb582b95c3076b289a60490b4948c9ab5b59571 but make install still fails because it creates an invalid symlink.
Comment 1 Jehan 2016-01-11 17:59:22 UTC
Could you please give me the exact error please? Also which operating system are you on?
On my machine, it works fine.
Comment 2 Jehan 2016-01-11 18:01:34 UTC
By the way, you don't have to comment on other unrelated bugs to get my attention. If you need me to look on a specific bug, add me to CC list and I'll receive an email.
Comment 3 Ben 2016-01-11 19:15:17 UTC
Sorry, so much to learn, didn't realize i could :) 

I'm on Ubuntu 15.10:
automake 1.15
autoconf 2.69
gcc/g++ 5.2.1
bash 4.3.42

Doing 'make install' i get :

================================================================
ln -s -f ../../icons/Symbolic/12/gimp-default-colors.png 12/gimp-default-colors.png
 /bin/mkdir -p '/opt/Apps/gimp-git/share/gimp/2.0/icons/Symbolic-Inverted/hicolor/12x12/apps'
 /usr/bin/install -c -m 644 12/gimp-close.png ./12/gimp-default-colors.png 12/gimp-linked.png 12/gimp-menu-left.png 12/gimp-menu-right.png 12/gimp-quick-mask-off.png 12/gimp-quick-mask-on.png 12/gimp-swap-colors.png 12/gimp-visible.png 12/gimp-zoom-follow-window.png '/opt/Apps/gimp-git/share/gimp/2.0/icons/Symbolic-Inverted/hicolor/12x12/apps'
/usr/bin/install: cannot stat ‘./12/gimp-default-colors.png’: No such file or directory
Makefile:1124: recipe for target 'install-icons12DATA' failed
make[3]: *** [install-icons12DATA] Error 1
make[3]: Leaving directory '/media/trekstor/gimp-commits/gimp-out/icons/Symbolic-Inverted'
Makefile:1446: recipe for target 'install-am' failed
make[2]: *** [install-am] Error 2
make[2]: Leaving directory '/media/trekstor/gimp-commits/gimp-out/icons/Symbolic-Inverted'
Makefile:605: recipe for target 'install-recursive' failed
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory '/media/trekstor/gimp-commits/gimp-out/icons'
Makefile:780: recipe for target 'install-recursive' failed
make: *** [install-recursive] Error 1
================================================================

ls -al reports the symlink as 

lrwxrwxrwx 1 foo foo   47 Jan 11 13:34 gimp-default-colors.png -> ../../icons/Symbolic/12/gimp-default-colors.png

but when i change it to have this

lrwxrwxrwx 1 foo foo   47 Jan 11 13:34 gimp-default-colors.png -> ../../Symbolic/12/gimp-default-colors.png

it then works fine and will install.
Comment 4 Jehan 2016-01-11 19:59:09 UTC
Could you try a `make clean` and build again?
Comment 5 Michael Natterer 2016-01-11 20:04:35 UTC
I just fixed this without having noticed the bug:

commit 3428a5c579102fc0c8e554ce237405e36bf7f946
Author: Michael Natterer <mitch@gimp.org>
Date:   Mon Jan 11 20:34:16 2016 +0100

    icons: use cp not LN_S to "create" the inverted 12/gimp-default-colors.png
    
    Linking it apparently messed up something (identical timestamps?) so
    sudo make install would fail.

 icons/Symbolic-Inverted/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Ben 2016-01-11 20:23:49 UTC
just did a new pull rebuilding with your changes.
Comment 7 Ben 2016-01-11 20:53:00 UTC
works