After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760438 - [PATCH] notify-send --help shows translated characters as question marks on some locales
[PATCH] notify-send --help shows translated characters as question marks on s...
Status: RESOLVED FIXED
Product: libnotify
Classification: Platform
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: libnotify-maint
libnotify-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-11 06:55 UTC by Ting-Wei Lan
Modified: 2016-10-22 03:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
notify-send: Call setlocale in main function (874 bytes, patch)
2016-01-11 06:56 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-01-11 06:55:15 UTC 
Please see the attached patch. notify-send should call setlocale in main function in order to correctly show translated messages.

Running 'notify-send --help' with zh_TW.UTF-8 locale shows:
???
  notify-send [???] <SUMMARY> [BODY] - create a notification

?????
  -?, --help                        ???????

???????
  -u, --urgency=LEVEL               Specifies the urgency level (low, normal, critical).
  -t, --expire-time=TIME            Specifies the timeout in milliseconds at which to expire the notification.
  -a, --app-name=APP_NAME           Specifies the app name for the icon
  -i, --icon=ICON[,ICON...]         Specifies an icon filename or stock icon to display.
  -c, --category=TYPE[,TYPE...]     Specifies the notification category.
  -h, --hint=TYPE:NAME:VALUE        Specifies basic extra data to pass. Valid types are int, double, string and byte.
  -v, --version                     Version of the package.
Comment 1 Ting-Wei Lan 2016-01-11 06:56:02 UTC 
Created attachment 318706 [details] [review]
notify-send: Call setlocale in main function

It is required to correctly show translated messages on some locales.
Comment 2 Ting-Wei Lan 2016-06-18 10:27:45 UTC 
Does anyone have time to review the patch? It has stayed here for more than 5 months.
Comment 3 Ting-Wei Lan 2016-07-16 16:02:15 UTC 
Does anyone have time to review the patch? It has stayed here for more than 6 months.
Comment 4 Ting-Wei Lan 2016-08-16 07:21:14 UTC 
Does anyone have time to review the patch? It has stayed here for more than 7 months.
Comment 5 Cosimo Cecchi 2016-10-22 00:18:35 UTC 
Review of attachment 318706 [details] [review]:

Looks good to me.
Comment 6 Ting-Wei Lan 2016-10-22 03:36:15 UTC 
Attachment 318706 [details] pushed as 5398ecf - notify-send: Call setlocale in main function