After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760437 - [PATCH] xpsto{jpeg,pdf,png,ps,svg} --help shows translated characters as question marks on some locales
[PATCH] xpsto{jpeg,pdf,png,ps,svg} --help shows translated characters as ques...
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-11 06:51 UTC by Ting-Wei Lan
Modified: 2016-01-31 09:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tools: Call setlocale in main function of gxps-converter-main.c (946 bytes, patch)
2016-01-11 06:53 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2016-01-11 06:51:31 UTC
Please see the attached patch. xpsto* tools should call setlocale in main function in order to correctly show translated messages.

Running 'xpstojpeg --help | head' with zh_TW.UTF-8 locale shows:
???
  xpstojpeg [???] FILE [OUTPUT FILE]

?????
  -?, --help                      ???????

???????
  -d, --document=DOCUMENT         the XPS document to convert
  -f, --first=PAGE                first page to convert
  -l, --last=PAGE                 last page to convert
Comment 1 Ting-Wei Lan 2016-01-11 06:53:01 UTC
Created attachment 318705 [details] [review]
tools: Call setlocale in main function of gxps-converter-main.c

It is required to correctly show translated messages on some locales.
Comment 2 Carlos Garcia Campos 2016-01-31 09:41:25 UTC
Comment on attachment 318705 [details] [review]
tools: Call setlocale in main function of gxps-converter-main.c

Pushed, thanks!