After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760435 - [PATCH] valadoc --help shows translated characters as question marks on some locales
[PATCH] valadoc --help shows translated characters as question marks on some ...
Status: RESOLVED FIXED
Product: valadoc
Classification: Other
Component: libvaladoc
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: valadoc-maint
valadoc-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-11 06:44 UTC by Ting-Wei Lan
Modified: 2016-10-18 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
valadoc: Call setlocale in main function (763 bytes, patch)
2016-01-11 06:46 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-01-11 06:44:25 UTC 
Please see the attached patch. valadoc should call setlocale in main function in order to correctly show translated messages.

Running 'valadoc --help | head' with zh_TW.UTF-8 locale shows:
???
  valadoc [???] FILE... - Vala Documentation Tool

?????
  -h, --help                         ???????

???????
  -o, --directory=DIRECTORY          Output directory
  -b, --basedir=DIRECTORY            Base source directory
  -D, --define=SYMBOL...             Define SYMBOL
Comment 1 Ting-Wei Lan 2016-01-11 06:46:06 UTC 
Created attachment 318703 [details] [review]
valadoc: Call setlocale in main function

It is required to correctly show translated messages on some locales.
Comment 2 Ting-Wei Lan 2016-06-18 10:31:30 UTC 
I know this is a trivial patch, but it is really required. An output with characters replaced by question marks is not readable. Does someone have time to review the patch?
Comment 3 Ting-Wei Lan 2016-07-16 16:02:53 UTC 
I think I need to ping again ... It has stayed here for more than 6 months.
Comment 4 Ting-Wei Lan 2016-08-16 07:21:28 UTC 
I think I really need to ping again ... It has stayed here for more than 7 months.
Comment 5 Rico Tzschichholz 2016-10-18 13:42:55 UTC 
Attachment 318703 [details] pushed as e95f549 - valadoc: Call setlocale in main function