After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760433 - [PATCH] nautilus-sendto --help shows translated characters as question marks on some locales
[PATCH] nautilus-sendto --help shows translated characters as question marks ...
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: nautilus-sendto-maint
nautilus-sendto-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-11 06:35 UTC by Ting-Wei Lan
Modified: 2016-03-02 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Call setlocale in main function (799 bytes, patch)
2016-01-11 06:37 UTC, Ting-Wei Lan 		committed Details | Review
main: Fix a missing include in the previous commit (623 bytes, patch)
2016-01-25 08:45 UTC, Ting-Wei Lan 		none Details | Review

Description Ting-Wei Lan 2016-01-11 06:35:55 UTC 
Please see the attached patch. nautilus-sendto should call setlocale in main function in order to correctly show translated messages.

Running 'nautilus-sendto --help' with zh_TW.UTF-8 locale shows:
???
  nautilus-sendto [???] [FILES...] 

?????
  -h, --help                   ???????

???????
  -b, --run-from-build-dir     ???????(???)
  -x, --xid                    ?? XID ??????????(???)
  -v, --version                ?????????
Comment 1 Ting-Wei Lan 2016-01-11 06:37:25 UTC 
Created attachment 318701 [details] [review]
main: Call setlocale in main function

It is required to correctly show translated messages on some locales.
Comment 2 Ting-Wei Lan 2016-01-25 08:45:35 UTC 
Created attachment 319662 [details] [review]
main: Fix a missing include in the previous commit
Comment 3 Bastien Nocera 2016-03-02 16:43:16 UTC 
Follow-up was in:

commit e49743759f3d9d2fd1ae76753e4161468c7253f3
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Feb 1 16:19:51 2016 +0100

    main: Fix build on some systems
    
    As a follow-up to 4b6a5146068e5c4f0d60aabbf2901bc9a9bce4a2, make sure to
    include locale.h to avoid setlocale() and LC_ALL not being defined.
    
    Those should already be dragged in by gi18n.h but it seems it doesn't work
    on some systems.
    
    ://bugzilla.gnome.org/show_bug.cgi?id=760664