After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760429 - [PATCH] gsound-play --help shows translated characters as question marks on some locales
[PATCH] gsound-play --help shows translated characters as question marks on s...
Status: RESOLVED FIXED
Product: gsound
Classification: Other
Component: general
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: GSound maintainer(s)
GSound maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-11 06:15 UTC by Ting-Wei Lan
Modified: 2019-02-08 22:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gsound-play: Call setlocale in main function (788 bytes, patch)
2016-01-11 06:17 UTC, Ting-Wei Lan 		none Details | Review

Description Ting-Wei Lan 2016-01-11 06:15:35 UTC 
Please see the attached patch. gsound-play should call setlocale in main function in order to correctly show translated messages.

Running 'gsound-play --help' with zh_TW.UTF-8 locale shows:
???
  gsound-play [???]

?????
  -h, --help                     ???????

???????
  -i, --id=STRING                Event sound identifier
  -f, --file=PATH                Play file
  -d, --description=STRING       Event sound description
  -c, --cache-control=STRING     Cache control (permanent, volatile, never
  -l, --loop=INTEGER             Loop many times (default: 1)
  -V, --volume=STRING            A floating point dB value for the sample volume (ex: 0.0)
  -b, --backend=STRING           libcanberra backend to use
Comment 1 Ting-Wei Lan 2016-01-11 06:17:14 UTC 
Created attachment 318697 [details] [review]
gsound-play: Call setlocale in main function

It is required to correctly show translated messages on some locales.
Comment 2 Ting-Wei Lan 2016-06-18 10:32:46 UTC 
I hope this can be resolved soon ... The patch has stayed in bugzilla for 5 months without being reviewed.
Comment 3 Ting-Wei Lan 2016-08-16 07:22:44 UTC 
The patch has stayed in bugzilla for 7 months without being reviewed. Can it be reviewed soon?
Comment 4 Ting-Wei Lan 2018-04-22 12:07:20 UTC 
Hello, the patch has stayed in bugzilla for 2 years now, and it is a trivial patch. Can we get it reviewed?
Comment 5 Ting-Wei Lan 2018-08-10 14:28:42 UTC 
Ping ... Please review the patch. It is trivial.
Comment 6 Jeremy Bicha 2019-02-08 22:09:10 UTC 
This has been merged:
https://gitlab.gnome.org/GNOME/gsound/merge_requests/2

Sorry about the delay.