After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760424 - [PATCH] gjs --help shows translated characters as question marks on some locales
[PATCH] gjs --help shows translated characters as question marks on some locales
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
1.45.x
Other FreeBSD
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-11 05:59 UTC by Ting-Wei Lan
Modified: 2016-07-19 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
console: Call setlocale before processing arguments (958 bytes, patch)
2016-01-11 06:00 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-01-11 05:59:39 UTC 
Please see the attached patch. gjs-console should call setlocale before processing command line arguments in order to correctly show translated messages in --help.

Running 'gjs --help' with zh_TW.UTF-8 locale shows:
???
  gjs [???]

???
  -c, --command=COMMAND        Program passed in as a string
  -C, --coverage-path=FILE     Add the filename FILE to the list of files to generate coverage info for
  --coverage-output=DIR        Write coverage output to a directory DIR. This option is mandatory when using --coverage-path
  -I, --include-path=DIR       Add the directory DIR to the list of directories to search for js files.
Comment 1 Ting-Wei Lan 2016-01-11 06:00:25 UTC 
Created attachment 318692 [details] [review]
console: Call setlocale before processing arguments

It is required to correctly show translated messages in 'gjs --help'.
Comment 2 Ting-Wei Lan 2016-07-16 16:03:23 UTC 
Does anyone have time to review the patch? It has stayed here for more than 6 months.
Comment 3 Cosimo Cecchi 2016-07-19 18:10:55 UTC 
Sorry it took so long! It's in master now -- thanks.

Attachment 318692 [details] pushed as bf1d819 - console: Call setlocale before processing arguments