GNOME Bugzilla – Bug 760415
session: Add a FIXME
Last modified: 2016-01-12 15:56:30 UTC
To explain why the code is not doing the thing that the comment above says it is doing.
Created attachment 318683 [details] [review] session: Add a FIXME
Review of attachment 318683 [details] [review]: It's a little confusing, but both NEW_VT and LOGIND_MANAGED rely on logind for managing the session. The difference is that in the case of NEW_VT, gdm will jump to the VT first, before starting the session, in a flicker free way. With LOGIND_MANAGED, GDM doesn't get involved at all and just lets logind/Xorg handle VT management. The reason GDM can't use LOGIND_MANAGED for Xorg, is an Xorg bug. It switches VTs before issuing the logind TakeControl() call, so it can potentially flicker. Anyway, I agree the comment that's there isn't detailed enough and that it's confusing, but I think that comment should give fixed instead of adding a new one that still leaves things pretty mysterious.
Created attachment 318835 [details] [review] session: Improve a comment and remove useless code Here's my stab at improving this comment... I also got rid of the entire condition for now, since it's not doing anything.
Thanks, the comment was much better, but I still wasn't satisified, so I redid it from scratch, and since we're collapsing down some of the different cases into one codepath, I consolidated all of them.