GNOME Bugzilla – Bug 760409
restore disk image not showing iso
Last modified: 2017-05-11 18:08:46 UTC
Running gnome-disk-utility 3.18.3.1 in Fedora 23. When I click on "Restore disk image..." and then browse to the folder where I have all the iso files, the files that are uppercase .ISO are filtered out. These files are perfectly valid and should be visible in my opinion. Renaming the files to lowercase .iso is a workaround.
line #91 in `gnome-disk-utility/src/libgdu/gduutils.c` seems to be the relevant filter. Maybe make use a custom filter that case insensitive?
Created attachment 351501 [details] [review] Changed file selector filter to use proper mime-types Here's a patch to fix the issue; it covers other accepted file types as well, not just .ISO.
Created attachment 351521 [details] [review] Use MIME types for disk images Hello, wonderful, I just needed to reorder a bit to match the case for compression correctly, thanks a lot! Regards, Kai
Review of attachment 351501 [details] [review]: Do you want your mail address mentioned?
Review of attachment 351501 [details] [review]: ::: src/libgdu/gduutils.c @@ +102,3 @@ if (allow_compressed) { + gtk_file_filter_add_mime_type (filter, "application/x-raw-disk-image"); x-raw-disk-image and x-raw-disk-image-xz-compressed are swapped
Created attachment 351531 [details] [review] Use MIME types for disk images I set you as author (Mitchell Horne <mhorne063@gmail.com>) now because your patch did have none, also the whitespace was removed in addition to the mime swap. You can have a look on https://wiki.gnome.org/Git/CommitMessages (e.g. my change to the commit message including the bug url).
Looks good to me, thanks! Sorry about the swap and the commit message, I had written a longer one but the description somehow got removed when I generated the patch.
No problem, your contribution is very appreciated :)