GNOME Bugzilla – Bug 760393
Stop using deprecated gnome-common and add hooks
Last modified: 2016-01-12 18:07:15 UTC
Gnome common is deprecated: https://wiki.gnome.org/Projects/GnomeCommon/Migration
Created attachment 318651 [details] [review] Replace deprecated gnome-common and add hooks
Review of attachment 318651 [details] [review]: ::: Makefile.am @@ +1,3 @@ SUBDIRS = data help po src +ACLOCAL_AMFLAGS = --install -I m4 ${ACLOCAL_FLAGS} Nope, ACLOCAL_AMFLAGS is deprecated. Instead use AC_CONFIG_MACRO_DIR([m4]) in configure.ac. Either way forces aclocal to copy needed m4 files from the system into the m4 directory. Where did you see advise to use this? @@ +3,3 @@ +ACLOCAL_AMFLAGS = --install -I m4 ${ACLOCAL_FLAGS} + +EXTRA_DIST = autogen.sh NEWS We don't want to distribute autogen.sh, since it has no purpose in tarballs. I think NEWS is automatically distributed? ::: configure.ac @@ +2,3 @@ AC_INIT([Five or More], [3.19.3], [https://bugzilla.gnome.org/], [five-or-more], [https://wiki.gnome.org/Apps/Five%20or%20more]) +AC_CONFIG_MACRO_DIR([m4]) Good.
(In reply to Michael Catanzaro from comment #2) > Where did you see advise to use this? I was just following gnome-chess, will fix gnome-chess as well. > I think NEWS is automatically distributed? I'm checking this but removed for now.
Fixed comments and pushed to master. To ssh://ssareen@git.gnome.org/git/five-or-more 4d9941c..036cedd master -> master
(In reply to Michael Catanzaro from comment #2) > I think NEWS is automatically distributed? Confirmed, you are right. ebassi on #gnome-hackers "sssareen: autotools automatically puts NEWS in the dist tarball, so you don't need to use EXTRA_DIST"
(In reply to Sahil Sareen from comment #3) > (In reply to Michael Catanzaro from comment #2) > > > Where did you see advise to use this? > > I was just following gnome-chess, will fix gnome-chess as well. But gnome-chess does not use ACLOCAL_AMFLAGS anymore. :)
(In reply to Michael Catanzaro from comment #6) > (In reply to Sahil Sareen from comment #3) > > (In reply to Michael Catanzaro from comment #2) > > > > > Where did you see advise to use this? > > > > I was just following gnome-chess, will fix gnome-chess as well. > > But gnome-chess does not use ACLOCAL_AMFLAGS anymore. :) Oh! Thats right again! :P I was looking at a stale branch.