After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760388 - MS lib files cannot be generated (with patch)
MS lib files cannot be generated (with patch)
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.18.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-01-10 04:17 UTC by Tom Schoonjans
Modified: 2016-01-15 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes Windows static library Makefile bug (1.38 KB, patch)
2016-01-10 04:18 UTC, Tom Schoonjans
committed Details | Review

Description Tom Schoonjans 2016-01-10 04:17:36 UTC
When building gtk+3 on Windows using MinGW/MSYS, I ran into a build error involving the generating of the .lib static libraries, due to a dependency on non-existent libtool archives, which like like an oversight during the gtk2 to gtk3 transition.

Anyway, the patch is attached.

Best,

Tom
Comment 1 Tom Schoonjans 2016-01-10 04:18:43 UTC
Created attachment 318635 [details] [review]
Fixes Windows static library Makefile bug
Comment 2 LRN 2016-01-13 22:06:44 UTC
Review of attachment 318635 [details] [review]:

This looks correct, but i can't test it, because i don't have MS lib.exe
Comment 3 Ignacio Casal Quinteiro (nacho) 2016-01-15 10:18:56 UTC
I've pushed the patch. If somebody complains we can always revert it, but I'd rather avoid having people not being able to build gtk on windows.
Comment 4 Tom Schoonjans 2016-01-15 10:22:12 UTC
Thanks for committing the patch!

FYI, this problem only affected installations where lib.exe would get picked up by configure. Otherwise the build would run without hiccups...