GNOME Bugzilla – Bug 760378
Cover art fetching broken for albums
Last modified: 2016-01-10 11:30:55 UTC
After the switch to grilo 0.3, gnome-music seems unable to fetch any cover art, this can be seen moving/deleting ~/.cache/media-art and running gnome-music from master. AFAICT, the culprit is around https://git.gnome.org/browse/grilo-plugins/tree/src/lua-factory/grl-lua-factory.c#n1656 . The grilo tracker source query used in gnome-music returns nmm:MusicAlbums, so we get GrlMedia that only pass the grl_media_is_container() check, however the lua plugins that implement cover downloading for music specify "audio" as the only supported media, so we bail out here. Arguably, containers should pass an "any" check, rather than an "all" check, I'm attaching a patch going that way.
Created attachment 318609 [details] [review] lua-factory: Make containers match any supported_media Individually, containers are not likely to represent all 3 of images/audio/video types at once, it feels a bit backwards that lua plugins must use "all" in order to provide information for containers. Fixes album cover fetching on gnome-music after the port to grilo 0.3.
Review of attachment 318609 [details] [review]: It should be any, not all. Indeed! ::: src/lua-factory/grl-lua-factory.c @@ +1656,3 @@ /* Verify if the source resolve type and media type match */ res_type = lua_source->priv->resolve_type; + if ((grl_media_is_container (media) && !(res_type & GRL_SUPPORTED_MEDIA_ALL)) Yes, indeed.
Thanks! pushed to master. Attachment 318609 [details] pushed as 56f96c0 - lua-factory: Make containers match any supported_media