After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760368 - workbench shows menubar under xfce
workbench shows menubar under xfce
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-09 16:44 UTC by Christian Hergert
Modified: 2016-05-30 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disable the menubar always (774 bytes, patch)
2016-01-09 18:36 UTC, sadath.anwar17 		none Details | Review
Disable the menubar always (800 bytes, patch)
2016-01-10 02:51 UTC, sadath.anwar17 		none Details | Review
Disable the menubar always (3.49 KB, patch)
2016-01-10 16:29 UTC, sadath.anwar17 		needs-work Details | Review
Disable menubar always (800 bytes, patch)
2016-01-10 16:42 UTC, sadath.anwar17 		none Details | Review
Disable menubar always. (801 bytes, patch)
2016-01-10 16:46 UTC, sadath.anwar17 		committed Details | Review

Description Christian Hergert 2016-01-09 16:44:12 UTC 
example: http://i.imgur.com/i2dABbw.png

we should disable the menubar always, since we aren't using it.

Set "show-menubar" property to false in data/ui/ide-workbench.ui (in the toplevel IdeWorkbench template).
Comment 1 sadath.anwar17 2016-01-09 18:36:42 UTC 
Created attachment 318594 [details] [review]
Disable the menubar always
Comment 2 Christian Hergert 2016-01-09 18:40:48 UTC 
Review of attachment 318594 [details] [review]:

This belongs after the <template ...>, and before the <child type="titlebar">
Comment 3 sadath.anwar17 2016-01-10 02:51:44 UTC 
Created attachment 318633 [details] [review]
Disable the menubar always
Comment 4 Christian Hergert 2016-01-10 16:11:55 UTC 
Review of attachment 318633 [details] [review]:

::: data/ui/ide-workbench.ui
@@ +3,3 @@
   <!-- interface-requires gtk+ 3.17 -->
   <template class="IdeWorkbench" parent="GtkApplicationWindow">
+<property name="show-menubar">false</property>

Indentation is incorrect.

Use <ctrl><alt>i in Builder (or == in vim mode) to fix the indentation and submit an updated patch.
Comment 5 sadath.anwar17 2016-01-10 16:29:53 UTC 
Created attachment 318660 [details] [review]
Disable the menubar always
Comment 6 Christian Hergert 2016-01-10 16:32:08 UTC 
Review of attachment 318660 [details] [review]:

Not sure what happened, but you've added a backup file (indicated by ~).
Comment 7 sadath.anwar17 2016-01-10 16:42:29 UTC 
Created attachment 318661 [details] [review]
Disable menubar always
Comment 8 sadath.anwar17 2016-01-10 16:46:35 UTC 
Created attachment 318663 [details] [review]
Disable menubar always.
Comment 9 Christian Hergert 2016-01-10 17:02:29 UTC 
Review of attachment 318661 [details] [review]:

LGTM, thanks for the fixes!
Comment 10 Christian Hergert 2016-01-10 17:03:48 UTC 
Review of attachment 318663 [details] [review]:

Ah great, this uses - instead of _, which is my preference.
Comment 11 Christian Hergert 2016-01-10 17:06:25 UTC 
Comment on attachment 318663 [details] [review]
Disable menubar always.

Pushed.

I want to have someone on Xfce test this though, before we close the bug.
Comment 12 Matthew Leeds 2016-05-30 16:28:42 UTC 
I just confirmed in XFCE that you fixed this in 7411fa9f1c2f7fb80f0251cb2e438aab07426b09 so we should be able to close this bug.
Comment 13 Christian Hergert 2016-05-30 22:47:30 UTC 
Thanks!