After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760355 - dlopen needs -ldl
dlopen needs -ldl
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-09 12:43 UTC by Hristo Venev
Modified: 2016-01-15 19:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use GModule API instead of dlopen() (2.57 KB, patch)
2016-01-12 15:39 UTC, Garrett Regier
committed Details | Review

Description Hristo Venev 2016-01-09 12:43:07 UTC
In contrib/egg/egg-counter.c
Comment 1 Garrett Regier 2016-01-12 15:39:26 UTC
Created attachment 318889 [details] [review]
Use GModule API instead of dlopen()

Why use dlopen() when we are already linking to gobject-2.0/gtk+-3.0 thus gmodule-2.0.
Comment 2 Christian Hergert 2016-01-12 16:56:50 UTC
Review of attachment 318889 [details] [review]:

LGTM. dlopen() was for historical reasons as this came from code I wrote a couple years ago.
Comment 3 Christian Hergert 2016-01-15 19:11:26 UTC
Attachment 318889 [details] pushed as fa6629e - Use GModule API instead of dlopen()