After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760332 - gnome-session cannot restart crashed gnome-shell on X11
gnome-session cannot restart crashed gnome-shell on X11
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-08 19:45 UTC by Ting-Wei Lan
Modified: 2016-01-18 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
manager: restart gnome-shell on X11 if it crashes (2.85 KB, patch)
2016-01-13 21:23 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ting-Wei Lan 2016-01-08 19:45:28 UTC 
As org.gnome.Shell.desktop contains 'X-GNOME-Autostart-Phase=DisplayServer', gnome-session thinks gnome-shell is a display server on both X11 and Wayland. This means that gnome-session exits when gnome-shell crashes on X11 instead of trying to restart it. It is very inconvenient because it is easy to crash gnome-shell on FreeBSD because of a GLib bug.
Comment 1 Ray Strode [halfline] 2016-01-13 21:23:32 UTC 
Created attachment 318988 [details] [review]
manager: restart gnome-shell on X11 if it crashes

gnome-shell calls itself a DisplayServer for ordering reasons,
and because we share one file between wayland an X11.

gnome-session currently doesn't try to restart a DisplayServer if
it crashes, since the presumption is the old session will come down
with it.

This commit restarts "display server" applications on anything but
wayland, because they can't actually be a display server in other
cases.
Comment 2 Ray Strode [halfline] 2016-01-13 21:23:50 UTC 
does this fix it?
Comment 3 Ting-Wei Lan 2016-01-14 16:02:32 UTC 
Yes, it can restart gnome-shell on X11 now.
Comment 4 Ray Strode [halfline] 2016-01-18 18:49:45 UTC 
Attachment 318988 [details] pushed as 91e74cc - manager: restart gnome-shell on X11 if it crashes