After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760255 - We do not want to be able to edit contacts
We do not want to be able to edit contacts
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-07 08:38 UTC by Jonas Danielsson
Modified: 2016-01-10 18:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
osmEdit: Disable editing for contacts (950 bytes, patch)
2016-01-10 11:59 UTC, Alex Anthony 		none Details | Review
osmEdit: Disable editing for contacts (932 bytes, patch)
2016-01-10 16:55 UTC, Alex Anthony 		committed Details | Review

Description Jonas Danielsson 2016-01-07 08:38:21 UTC 
Right now we get the edit-button and edit possibility when looking at a mapBubble of a contact. This should not happen.

This should probably be fixed in src/placeBubble.js
Comment 1 Karanbir Chahal 2016-01-07 17:55:51 UTC 
How do I check if bubble is a bubble for a contact?
Comment 2 Jonas Danielsson 2016-01-07 18:12:05 UTC 
(In reply to Karanbir Chahal from comment #1)
> How do I check if bubble is a bubble for a contact?

That is the task. Please study the code to find out. Look for other places were we check if a place is a contsct.
Comment 3 Jonas Danielsson 2016-01-07 18:12:38 UTC 
(In reply to Karanbir Chahal from comment #1)
> How do I check if bubble is a bubble for a contact?

That is the task. Please study the code to find out. Look for other places were we check if a place is a contsct.
Comment 4 Alex Anthony 2016-01-10 11:59:03 UTC 
Created attachment 318650 [details] [review]
osmEdit: Disable editing for contacts

Don't show the edit button on contact place marker bubbles
Comment 5 Jonas Danielsson 2016-01-10 13:53:35 UTC 
Review of attachment 318650 [details] [review]:

Thanks!

::: src/placeBubble.js
@@ +92,3 @@
+        } else {
+            this._initEditButton(this._editButton);
+        }

No need for braces in these.
Comment 6 Alex Anthony 2016-01-10 16:55:35 UTC 
Created attachment 318664 [details] [review]
osmEdit: Disable editing for contacts

Don't show the edit button on contact place marker bubbles
Comment 7 Hashem Nasarat 2016-01-10 16:58:18 UTC 
Is there a way to have the edit button on contacts open GNOME Contacts focused on that contact?
Comment 8 Jonas Danielsson 2016-01-10 18:24:27 UTC 
(In reply to Hashem Nasarat from comment #7)
> Is there a way to have the edit button on contacts open GNOME Contacts
> focused on that contact?

That is a nice idea. It depends on if Contacts define any suitable GAction that we can call via DBus. See how do for weather and clocks in sendToDialog for example.

We could add such an action if it does not exist. But I think I will push this patch for now.

Hashem: Feel free to file a bug, but maybe more general? => A way to open contact in Contacts from placeBubble?

And your suggestion here can be a sugestion in that bug? Or maybe we add contacts to sendToDialog if it is a ContactPlace, not sure.
Comment 9 Jonas Danielsson 2016-01-10 18:25:00 UTC 
Review of attachment 318664 [details] [review]:

Looks great! Thanks Alex!
Comment 10 Jonas Danielsson 2016-01-10 18:25:13 UTC 
Attachment 318664 [details] pushed as bf66c74 - osmEdit: Disable editing for contacts