After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760234 - playbin: Assumes recursive accept-caps query, breaks totem
playbin: Assumes recursive accept-caps query, breaks totem
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 760867 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-01-06 18:37 UTC by Iain Lane
Modified: 2016-01-19 23:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
*:6 log (355.55 KB, application/x-xz)
2016-01-06 18:37 UTC, Iain Lane
  Details
playbin: Use the caps query instead of accept-caps to detect if a sink accepts caps (2.58 KB, patch)
2016-01-07 13:26 UTC, Sebastian Dröge (slomo)
committed Details | Review
Debug log stb pli50 image double stream launch. (9.06 KB, text/plain)
2016-01-11 12:05 UTC, christophe vr
  Details

Description Iain Lane 2016-01-06 18:37:07 UTC
Created attachment 318377 [details]
*:6 log

I get "This file cannot be played over the network. Try downloading it locally first." when launching a file with totem directly from the commandline (from the index thing is also broken).

The attached log is from

  jhbuild run totem --gst-debug=\*:6 ~/Videos/g-t.mp4 --gst-plugin-spew --gst-debug-no-color 2>&1 | tee totem.log

It's from jhbuild so ignore the gtk warnings.

gst-play-1.0 <the same file> does work.
Comment 1 Sebastian Dröge (slomo) 2016-01-06 18:44:20 UTC
Regression introduced by 7f5f1df59b6573eaee11bb02af53d3799c33552d. Problem here is that playbin checks if a sink supports some caps by doing an accept-caps query. totem sets a bin with a capsfilter as sink, and the capsfilter has an ANY filter.
Comment 2 Sebastian Dröge (slomo) 2016-01-06 18:45:57 UTC
Might also be a bug in playbin of course, maybe playbin should actually just try intersecting with the caps query result?
Comment 3 Tim-Philipp Müller 2016-01-06 18:50:04 UTC
To reproduce without Totem:
gst-play-1.0 /path/to/foo.flac --audiosink='capsfilter ! pulsesink'
Comment 4 Sebastian Dröge (slomo) 2016-01-07 13:26:17 UTC
Created attachment 318416 [details] [review]
playbin: Use the caps query instead of accept-caps to detect if a sink accepts caps

accept-caps is only for one element, caps query is recursive. Fixes playback
with totem and other situations.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2016-01-07 17:42:04 UTC
Comment on attachment 318416 [details] [review]
playbin: Use the caps query instead of accept-caps to detect if a sink accepts caps

Thanks. This fixes the issue for me.
Comment 6 Sebastian Dröge (slomo) 2016-01-08 12:36:51 UTC
I'm not sure if this is the right fix though, there's probably a lot of code like the one I changed out there :)
Comment 7 Sebastian Dröge (slomo) 2016-01-08 14:15:38 UTC
It might also make Thiago's optimizations meaningless.
Comment 8 Sebastian Dröge (slomo) 2016-01-08 14:34:22 UTC
Attachment 318416 [details] pushed as 844aa3e - playbin: Use the caps query instead of accept-caps to detect if a sink accepts caps
Comment 10 Sebastian Dröge (slomo) 2016-01-11 11:58:09 UTC
That doesn't really make sense and is probably related to some other problem. Can you file a new bug with full debug logs?
Comment 11 christophe vr 2016-01-11 12:05:48 UTC
Created attachment 318714 [details]
Debug log stb pli50 image double stream launch.
Comment 12 christophe vr 2016-01-11 12:07:22 UTC
I added attachement. A full log is to heavy but here we info and looks like EVENT stream-start is send by stream which is already started.
Comment 13 Sebastian Dröge (slomo) 2016-01-11 12:09:34 UTC
Please open a new bug report with a as full as possible debug log :)
Comment 14 Sebastian Dröge (slomo) 2016-01-11 12:10:09 UTC
This one doesn't contain enough information, nothing useful for this specific bug at least.
Comment 15 christophe vr 2016-01-11 13:03:02 UTC
Yes but due to memory limitations we limited hat we can debug.

Off which modules do You need debug ?

so I can run them with GST_DEBUG=<module>:5  ?
Comment 16 christophe vr 2016-01-11 16:20:00 UTC
new bug due to commit :

https://bugzilla.gnome.org/show_bug.cgi?id=760477
Comment 17 Tim-Philipp Müller 2016-01-19 23:14:34 UTC
*** Bug 760867 has been marked as a duplicate of this bug. ***