After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760222 - videopool: store videoinfo after choosing the biggest buffer size
videopool: store videoinfo after choosing the biggest buffer size
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.6.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-06 15:07 UTC by Aurélien Zanelli
Modified: 2016-01-11 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videopool: store videoinfo after choosing the biggest buffer size (1.08 KB, patch)
2016-01-06 15:08 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2016-01-06 15:07:40 UTC 
When configuring size of a videopool, if pool size is greater than the video info size got from caps, value is accepted and pool is configured accordingly.
But we currently store the pool video info before size modification which causes inconsistency between pool configuration and pool stored video info which are used in allocation function.
Hence allocated buffers have wrong size.
Comment 1 Aurélien Zanelli 2016-01-06 15:08:47 UTC 
Created attachment 318337 [details] [review]
videopool: store videoinfo after choosing the biggest buffer size

Just store video info after setting info.size.
Comment 2 Nicolas Dufresne (ndufresne) 2016-01-06 16:32:25 UTC 
Attachment 318337 [details] pushed as c119715 - videopool: store videoinfo after choosing the biggest buffer size
Comment 3 Nicolas Dufresne (ndufresne) 2016-01-06 16:32:53 UTC 
Thanks, good catch.
Comment 4 Tim-Philipp Müller 2016-01-11 22:18:14 UTC 
Cherry-picked into 1.6 as well.
Comment 5 Nicolas Dufresne (ndufresne) 2016-01-11 23:17:31 UTC 
Thanks.