After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760221 - [PATCH] Playback sample with gtksink element
[PATCH] Playback sample with gtksink element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-sharp
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-06 15:06 UTC by Yannick Inizan
Modified: 2016-05-03 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix samples build (9.54 KB, patch)
2016-01-06 15:06 UTC, Yannick Inizan 		none Details | Review
Add new sample (3.35 KB, patch)
2016-01-06 16:34 UTC, Yannick Inizan 		none Details | Review
Add new sample (12.54 KB, patch)
2016-01-06 16:52 UTC, Yannick Inizan 		none Details | Review
[PATCH] Add playback sample with gtksink element. Requires GStreamer >= 1.7.1 (3.90 KB, patch)
2016-05-02 02:25 UTC, Yannick Inizan 		none Details | Review

Description Yannick Inizan 2016-01-06 15:06:01 UTC 
Created attachment 318336 [details] [review]
fix samples build

static methods are in Gst.Global class.
Comment 1 Yannick Inizan 2016-01-06 16:34:46 UTC 
Created attachment 318345 [details] [review]
Add new sample
Comment 2 Yannick Inizan 2016-01-06 16:52:44 UTC 
Created attachment 318348 [details] [review]
Add new sample
Comment 3 Sebastian Dröge (slomo) 2016-01-06 17:16:17 UTC 
Comment on attachment 318336 [details] [review]
fix samples build

This one doesn't apply to latest git master.
Comment 4 Sebastian Dröge (slomo) 2016-01-06 17:20:22 UTC 
Comment on attachment 318348 [details] [review]
Add new sample

Please split the "fix old samples" and "add new sample" part into two patches :)
Comment 5 Stephan Sundermann 2016-01-08 00:46:20 UTC 
Static methods should not be in Gst.Global but in their own classes. Gst.Parse.Launch is a valid function at least in my build. Which gtk# are you generating your bindings with?
Comment 6 Yannick Inizan 2016-01-08 01:40:20 UTC 
ok. this is my mono env. :
mono version : Mono JIT compiler version 4.3.2 (Nightly 4.3.2.155/9115bf0 Thu Dec 31 16:03:47 UTC 2015) (from mono repositories)
gtk-sharp3 : 2.99.4 (git)
Comment 7 Sebastian Dröge (slomo) 2016-02-16 14:33:54 UTC 
Stephan?
Comment 8 Stephan Sundermann 2016-04-27 14:03:48 UTC 
This issue should be resolved in git master. You added the sample on top of fixing the build issues. Can you create a patch with just the added sample included?
Comment 9 Yannick Inizan 2016-05-02 02:25:01 UTC 
Created attachment 327121 [details] [review]
[PATCH] Add playback sample with gtksink element. Requires GStreamer >= 1.7.1
Comment 10 Stephan Sundermann 2016-05-02 09:59:58 UTC 
If this patch requires gstreamer 1.7.1+ then I'm going to postpone merging a bit. I don't feel the requirement should be bumped to 1.8 when gstreamer-sharp isn't actually binding new API. Bumping the version just forces users to upgrade for a new sample when there is no new API.
Comment 11 Tim-Philipp Müller 2016-05-02 10:10:04 UTC 
Stephan - perhaps it's time to make a 1.x.0 release (whatever the current requirement is), then branch off a 1.x branch and continue tracking newer versions in master. Last release was in January 2014..
Comment 12 Stephan Sundermann 2016-05-03 03:30:29 UTC 
The problem is that gstreamer-sharp depends on changes currently in gtk-sharp master which hadn't had a release for ages now. That's why I cannot release gstreamer-sharp 1.4.0
Comment 13 Sebastian Dröge (slomo) 2016-05-03 09:24:22 UTC 
Is it expected that gtk-sharp is going to have a release any time in the near future again?
Comment 14 Stephan Sundermann 2016-05-03 12:18:45 UTC 
I don't think so gtk-sharp master seems to be kinda unmaintained right now.