After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760189 - Don't require Telepathy when built with --disable-telepathy
Don't require Telepathy when built with --disable-telepathy
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Telepathy
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-05 23:55 UTC by Cosimo Cecchi
Modified: 2016-01-11 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Completely disable telepathy when built with --disable-telepathy (8.81 KB, patch)
2016-01-05 23:55 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2016-01-05 23:55:12 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2016-01-05 23:55:14 UTC 
Created attachment 318301 [details] [review]
Completely disable telepathy when built with --disable-telepathy

Currently the --disable-telepathy switch only removes the telepathy
account provider from the list.
Instead, completely remove the (then unused) telepathy dependency when
the switch is disabled.
Comment 2 Michael Catanzaro 2016-01-06 21:26:25 UTC 
Review of attachment 318301 [details] [review]:

::: configure.ac
@@ -94,0 +94,11 @@
+# Telepathy
+AC_DEFINE(GOA_TELEPATHY_NAME, ["telepathy"], [ProviderType and extension point name])
+AC_ARG_ENABLE([telepathy],
... 8 more ...

I was not sure about having both GOA_TELEPATHY_ENABLED and BUILD_TELEPATHY, but I see you're following the style for Kerberos (GOA_KERBEROS_ENABLED and BUILD_KERBEROS).
Comment 3 Debarshi Ray 2016-01-11 18:01:58 UTC 
Review of attachment 318301 [details] [review]:

Thanks Cosimo. Pushed it to master after slightly tweaking the commit message.