GNOME Bugzilla – Bug 760170
Songs view - odd check box style and position
Last modified: 2016-02-02 12:18:13 UTC
The check boxes that are shown in the songs view (for selection mode) don't look right. They are very small and have an unnecessary border around them. They look like the overlaid check boxes that are used in grid views, that have been scaled down. This style shouldn't be used in lists - instead, standard checkboxes should be used. Also, the checkboxes have a non-standard position in the list: they should be placed at the start of the row before the track title, not after it.
(In reply to Allan Day from comment #0) > The check boxes that are shown in the songs view (for selection mode) don't > look right. They are very small and have an unnecessary border around them. > > They look like the overlaid check boxes that are used in grid views, that > have been scaled down. This style shouldn't be used in lists - instead, > standard checkboxes should be used. > > Also, the checkboxes have a non-standard position in the list: they should > be placed at the start of the row before the track title, not after it. I think I corrected the check buttons appearing to be wierd. I still have to reposition them to start of the row but please do look at these snapshots and tell me whether these will do: http://postimg.org/image/3zryxbg4x/ In case you are wondering about why they appear to be invisible, well thats the case for the check buttons even in Artist selection mode http://postimg.org/image/noiafpc8b/ The above snapshot was from the jhbuil(t) gnome-music, whereas the actual Gnome Music installed application shows them perfectly: http://postimg.org/image/u32in232n/ Maybe its another different bug or a missing dependency on my end. Please let me know what you think.
Created attachment 319870 [details] [review] Checkbutton proposed fix
(In reply to Saiful B. Khan from comment #2) > Created attachment 319870 [details] [review] [review] > Checkbutton proposed fix Looks good to me. One thing I noticed is that the checkboxes for selection mode when viewing a single album also need updating. It would be nice if those could be fixed too.
Created attachment 320211 [details] [review] Fixed Albums view
Review of attachment 319870 [details] [review]: Allan, do we want to move the checkbuttons from the right side of the Song name to the left?
Review of attachment 320211 [details] [review]: Sure.
Review of attachment 319870 [details] [review]: (In reply to Felipe Borges from comment #5) > Review of attachment 319870 [details] [review] [review]: > > Allan, do we want to move the checkbuttons from the right side of the Song > name to the left? Saiful told me on IRC that he had previously discussed that with Allan Day.
(In reply to Felipe Borges from comment #7) > Review of attachment 319870 [details] [review] [review]: > > (In reply to Felipe Borges from comment #5) > > Review of attachment 319870 [details] [review] [review] [review]: > > > > Allan, do we want to move the checkbuttons from the right side of the Song > > name to the left? > > Saiful told me on IRC that he had previously discussed that with Allan Day. That's right! Thanks for the fix, Saiful!