GNOME Bugzilla – Bug 760127
mpegtsmux: Reserve bits not set to to 1's
Last modified: 2016-01-11 23:30:30 UTC
Created attachment 318222 [details] sets the reserve bits to 1 to comply with standard. The MPEG TS stream is not compliant due to reserve bits not being set to 1 in the PCR and OPCR in the adaptation field.
Oops, forgot to put what component this was for. This is a patch for tsmux.c in the mpegtsmux library.
Hi. Thanks for your patch. Any chance you can send a git formatted one though? Also, you might want to take a look at http://gstreamer.freedesktop.org/wiki/SubmittingPatches/ for related instructions.
Created attachment 318266 [details] [review] Git formatted patch Sorry for the earlier patch. Here is a correctly formatted one. Thanks for pointing out the directions! cheers, Bob
Review of attachment 318266 [details] [review]: Thanks for the new patch. I don't have access to the standard so can't really comment on its correctness but in the mean time, please correct the following: ::: gst/mpegtsmux/tsmux/tsmux.c @@ +936,3 @@ fail: + if (packet) + g_free (packet); Unrelated and unneeded, please remove the 'if', g_free is NULL safe.
Created attachment 318287 [details] [review] updated patch I don't remember why I thought that was needed. Sorry for the confusion. Cheers, Bob
Thanks for the patch! I ran gst-indent over it and pushed it: commit cb520dce269b22eb105f19eac6f7abb4c13c86de Author: Bob Holcomb <bholcomb@mak.com> Date: Tue Jan 5 14:35:11 2016 -0500 mpegtsmux: fix reserve bits so they are 1's The MPEG standard (ISO-13880-1) says the reserve bits need to be set to one (2.1.64). This is causing transport streams to fail validation on some systems. https://bugzilla.gnome.org/show_bug.cgi?id=760127 Did you also check the rest of the code whether we're correctly setting bits to 1 there, or did you just fix up what your validator complained about?
Picked into 1.6 branch as well.