After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760120 - dashdemux: memory leak in gst_dash_demux_update_manifest_data
dashdemux: memory leak in gst_dash_demux_update_manifest_data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-04 12:13 UTC by Florin Apostol
Modified: 2016-02-09 20:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.90 KB, patch)
2016-01-04 12:15 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2016-01-04 12:13:35 UTC 
During manifest update, the new manifest is parsed using a separate mpd_client (new_client). This variable is not freed in case of errors.

Also, the buffer is not unmapped.
Comment 1 Florin Apostol 2016-01-04 12:15:42 UTC 
Created attachment 318207 [details] [review]
proposed patch
Comment 2 Thiago Sousa Santos 2016-02-09 20:47:07 UTC 
commit 632111ae144034b783eca28a24fc94669f49d0c6
Author: Thiago Santos <thiagoss@osg.samsung.com>
Date:   Tue Feb 9 17:24:50 2016 -0300

    dashdemux: plug mpd client leak
    
    On parsing error, free the mpd client object
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760120

commit 319105182879a9e2a06a5e9d9f46219fc1430c15
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Mon Jan 4 12:12:45 2016 +0000

    dashdemux: fix memory leak in gst_dash_demux_update_manifest_data
    
    new_client local variable was not freed in case of errors.
    Also, the buffer is not unmapped.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760120