After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760108 - Build failure in master
Build failure in master
Status: RESOLVED FIXED
Product: libgfbgraph
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GFBGraph maintainer(s)
GFBGraph maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-03 23:51 UTC by Javier Jardón (IRC: jjardon)
Modified: 2016-01-09 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
m4: Removed unnecessary m4 files (334.04 KB, patch)
2016-01-05 16:17 UTC, Álvaro Peña 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2016-01-03 23:51:58 UTC 
Please see http://build.gnome.org/continuous/buildmaster/builds/2016/01/03/40/build/log-libgfbgraph.txt

Probably you dont need to keep libtool m4 files in tree
Comment 1 Javier Jardón (IRC: jjardon) 2016-01-03 23:53:57 UTC 
Please revert https://git.gnome.org/browse/gnome-continuous/commit/?id=9d1572196e45cc43881f9dc507db745d21d7d510 when this is believed to be fixed.
Comment 2 Álvaro Peña 2016-01-05 16:17:22 UTC 
Created attachment 318263 [details] [review]
m4: Removed unnecessary m4 files
Comment 3 Álvaro Peña 2016-01-05 16:20:57 UTC 
(In reply to Javier Jardón (IRC: jjardon) from comment #0)
> Please see
> http://build.gnome.org/continuous/buildmaster/builds/2016/01/03/40/build/log-
> libgfbgraph.txt
> 
> Probably you dont need to keep libtool m4 files in tree

Just removed the unnecessary m4 files (I think that introspection.m4 is required in some systems... but just guessing)

How can I test it before the final commit? I have not libtool 2.4.2...

Thanks for the bug report!
Comment 4 Javier Jardón (IRC: jjardon) 2016-01-05 17:54:09 UTC 
(In reply to Álvaro Peña from comment #3)
> (In reply to Javier Jardón (IRC: jjardon) from comment #0)
> > Please see
> > http://build.gnome.org/continuous/buildmaster/builds/2016/01/03/40/build/log-
> > libgfbgraph.txt
> > 
> > Probably you dont need to keep libtool m4 files in tree
> 
> Just removed the unnecessary m4 files (I think that introspection.m4 is
> required in some systems... but just guessing)
> 
> How can I test it before the final commit? I have not libtool 2.4.2...

Just be sure it compiles; it will compile for others version of libtool as autoreconf will generate the correct m4 files, depending of the libtool version the different systems have
Comment 5 Álvaro Peña 2016-01-09 12:02:40 UTC 
Comment on attachment 318263 [details] [review]
m4: Removed unnecessary m4 files

Attachment 318263 [details] pushed as 191e538 - m4: Removed unnecessary m4 files
Comment 6 Álvaro Peña 2016-01-09 12:08:54 UTC 
(In reply to Javier Jardón (IRC: jjardon) from comment #1)
> Please revert
> https://git.gnome.org/browse/gnome-continuous/commit/
> ?id=9d1572196e45cc43881f9dc507db745d21d7d510 when this is believed to be
> fixed.

Reverted in https://git.gnome.org/browse/gnome-continuous/commit/?id=137e4f60398ad8934eb637202ff639da2517cc32