After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760101 - Heap-buffer overread in ms-obj.c:1134 on a fuzzed xls file
Heap-buffer overread in ms-obj.c:1134 on a fuzzed xls file
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
git master
Other Linux
: Normal critical
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2016-01-03 21:32 UTC by jutaky
Modified: 2016-01-04 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description jutaky 2016-01-03 21:32:39 UTC 
Git versions of gtk, glib, goffice, gnumeric, libgsf and libxml2.

Test case: http://jutaky.com/fuzzing/gnumeric_case_005-ms-obj.c.1134.xls

$ ssconvert gnumeric_case_005-ms-obj.c.1134.xls /tmp/out.gnumeric

==25685==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020001cc1f8 at pc 0x7fe23a326de7 bp 0x7ffc2fb974d0 sp 0x7ffc2fb974c8
READ of size 1 at 0x6020001cc1f8 thread T0
    #0 0x7fe23a326de6 in ms_obj_read_biff8_obj gnumeric/gnumeric/plugins/excel/ms-obj.c:1134:28
    #1 0x7fe23a326de6 in ms_read_OBJ gnumeric/gnumeric/plugins/excel/ms-obj.c:1294
    #2 0x7fe23a279596 in ms_escher_read_ClientData gnumeric/gnumeric/plugins/excel/ms-escher.c:2063:6
    #3 0x7fe23a271711 in ms_escher_read_container gnumeric/gnumeric/plugins/excel/ms-escher.c:2181:10
    #4 0x7fe23a271711 in ms_escher_read_container gnumeric/gnumeric/plugins/excel/ms-escher.c:2181:10
    #5 0x7fe23a271711 in ms_escher_read_container gnumeric/gnumeric/plugins/excel/ms-escher.c:2181:10
    #6 0x7fe23a271711 in ms_escher_read_container gnumeric/gnumeric/plugins/excel/ms-escher.c:2181:10
    #7 0x7fe23a2709eb in ms_escher_parse gnumeric/gnumeric/plugins/excel/ms-escher.c:2248:2
    #8 0x7fe23a29fe41 in excel_read_sheet gnumeric/gnumeric/plugins/excel/ms-excel-read.c:6819:4
    #9 0x7fe23a29380d in excel_read_BOF gnumeric/gnumeric/plugins/excel/ms-excel-read.c:7119:4
    #10 0x7fe23a28acb2 in excel_read_workbook gnumeric/gnumeric/plugins/excel/ms-excel-read.c:7228:4
    #11 0x7fe23a2637a2 in excel_enc_file_open gnumeric/gnumeric/plugins/excel/boot.c:193:2
    #12 0x7fe259237ed2 in go_plugin_loader_module_func_file_open gnumeric/goffice/goffice/app/go-plugin-loader-module.c:282:3
    #13 0x7fe259240b96 in go_plugin_file_opener_open gnumeric/goffice/goffice/app/go-plugin-service.c:685:2
    #14 0x7fe259244cec in go_file_opener_open gnumeric/goffice/goffice/app/file.c:417:2
    #15 0x7fe259e43d00 in workbook_view_new_from_input gnumeric/gnumeric/src/workbook-view.c:1278:3
    #16 0x7fe259e4407f in workbook_view_new_from_uri gnumeric/gnumeric/src/workbook-view.c:1337:9
    #17 0x4dd2b5 in convert gnumeric/gnumeric/src/ssconvert.c:715:9
    #18 0x4dc6f4 in main gnumeric/gnumeric/src/ssconvert.c:918:19
    #19 0x7fe253ea960f in __libc_start_main (/usr/lib/libc.so.6+0x2060f)
    #20 0x41a688 in _start (apps/bin/ssconvert+0x41a688)

--
Juha Kylmänen
Comment 1 Morten Welinder 2016-01-04 15:26:00 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.