GNOME Bugzilla – Bug 760092
Text Size plugin: Ctrl + Scrollwheel (mouse wheel) moves text instead of just zooming
Last modified: 2019-03-23 20:34:36 UTC
Steps to reproduce: 1. start gedit 2. enable text size plugin 3. open text file with 300 lines at 1280x720 window size 4. While line 1 is visible, hold down Ctrl and use the mousewheel downwards Expected: Fonts grow bigger, equal to as if you had pressed Ctrl + + Actual: Fonts grow bigger but also the scroll is being interpreted as movement Video of issue: https://youtu.be/iZjTjwSP7RU Additional note: In many pieces of software, pressing Shift in "Ctrl + Shift + =" to get "Ctrl + +" is optional and they allow pressing "Ctrl + Shift + -" to get "Ctrl + -". For example: Chrome.
I confirm the bug, except that when I move the mousewheel downward, the text shrinks, not becomes bigger (but it's maybe a difference in the mousewheel config).
Created attachment 356922 [details] [review] Fixed bug #760092 - Text Size plugin: Ctrl + Scrollwheel (mouse wheel) moves text instead of just zooming The textsize plugin now tries to keep the currently central line in the middle.
Review of attachment 356922 [details] [review]: The code looks good, if it works. The commit message should follow these guidelines: https://wiki.gnome.org/Git/CommitMessages So the full URL to the bug at the end.
Created attachment 356966 [details] [review] Fixed bug #760092 - Text Size plugin: Ctrl + Scrollwheel (mouse wheel) moves text instead of just zooming The textsize plugin now tries to keep the currently central line in the middle.
Pushed: https://git.gnome.org/browse/gedit-plugins/commit/?id=3d5becb43d242766ec3c69d1ad9082f81eba730f Thanks!